Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several traffic profiles include deprecated generator fields (min_clients and clients_per_gb) #135

Open
mcallaghan-sandvine opened this issue Aug 15, 2018 · 0 comments

Comments

@mcallaghan-sandvine
Copy link
Contributor

as per https://trex-tgn.cisco.com/trex/doc/trex_manual.html#_global_traffic_yaml_section

          clients_per_gb : 201             9
          min_clients    : 101             10

, this is one of MANY examples where we reference a deprecated parameter:

  | Deprecated. not used
  | Deprecated. not used

we can also search in the entire code base and find this all over :(

--
can this stuff be removed and cleaned up?

$ pwd
~/projects/trex-core/scripts

$ grep -rins min_clients *
automation/trex_control_plane/client_utils/trex_yaml_gen.py:21:                                    'min_clients': 101,
automation/regression/cfg/imix.yaml:13:          min_clients    : 101
automation/regression/cfg/imix_fast_1g.yaml:14:          min_clients    : 101
avl/sfr_delay_10_1g_asa_nat.yaml:9:          min_clients    : 101
avl/sfr_delay_10_1g.yaml:9:          min_clients    : 101
avl/sfr_delay_10_1g_no_bundeling.yaml:9:          min_clients    : 101
avl/sfr_branch_profile_delay_10.yaml:9:          min_clients    : 101
avl/sfr_delay_10_no_bundeling.yaml:9:          min_clients    : 101
avl/sfr_delay_50_tunnel_no_bundeling.yaml:9:          min_clients    : 101
avl/sfr_delay_10.yaml:9:          min_clients    : 101
cap2/cur_flow.yaml:9:          min_clients    : 101
cap2/cur_flow_single_tw_8.yaml:9:          min_clients    : 101
cap2/http_very_long.yaml:9:          min_clients    : 101
cap2/lb_ex1.yaml:9:          min_clients    : 101
cap2/per_template_gen4.yaml:9:          min_clients    : 101
cap2/per_template_gen5.yaml:9:          min_clients    : 101
cap2/rtsp.yaml:9:          min_clients    : 101
cap2/per_template_gen3.yaml:9:          min_clients    : 101
cap2/per_template_gen1.yaml:9:          min_clients    : 101
cap2/http.yaml:9:          min_clients    : 101
cap2/test_pcap_mode2.yaml:9:          min_clients    : 101
cap2/ipv6_load_balance.yaml:9:          min_clients    : 101
cap2/dns_single_server.yaml:9:          min_clients    : 101
cap2/dns_wlen.yaml:9:          min_clients    : 101
cap2/sip_short2.yaml:9:          min_clients    : 101
cap2/short_tcp.yaml:9:          min_clients    : 101
cap2/rtsp_full2.yaml:9:          min_clients    : 101
cap2/imix_9k.yaml:12:          min_clients    : 101
cap2/rtsp_short3.yaml:9:          min_clients    : 101
cap2/cur_flow_single.yaml:9:          min_clients    : 101
cap2/imix_64.yaml:12:          min_clients    : 101
cap2/imix_64_100k.yaml:12:          min_clients    : 101
cap2/http_simple_ipv6.yaml:9:          min_clients    : 101
cap2/asa_explot1.yaml:9:          min_clients    : 101
cap2/imix_64_fast.yaml:12:          min_clients    : 101
cap2/many_client_example.yaml:9:          min_clients    : 101
cap2/sfr2.yaml:9:          min_clients    : 101
cap2/http_simple.yaml:9:          min_clients    : 101
cap2/dns_wlen1.yaml:9:          min_clients    : 101
cap2/wrong_ip.yaml:9:          min_clients    : 101
cap2/dns_one_server.yaml:9:          min_clients    : 101
cap2/sfr3.yaml:9:          min_clients    : 101
cap2/test_pcap_mode1.yaml:9:          min_clients    : 101
cap2/dyn_pyld1.yaml:9:          min_clients    : 101
cap2/imix_1518.yaml:12:          min_clients    : 101
cap2/per_template_gen2.yaml:9:          min_clients    : 101
cap2/http_short.yaml:9:          min_clients    : 101
cap2/dns_wlen2.yaml:9:          min_clients    : 101
cap2/jumbo.yaml:9:          min_clients    : 101
cap2/limit_multi_pkt.yaml:12:          min_clients    : 101
cap2/ipv4_load_balance.yaml:9:          min_clients    : 101
cap2/nat_test.yaml:10:          min_clients    : 101
cap2/sfr.yaml:9:          min_clients    : 101
cap2/dns_tw.yaml:9:          min_clients    : 101
cap2/sfr4.yaml:9:          min_clients    : 101
cap2/dns_no_delay.yaml:9:          min_clients    : 101
cap2/rtsp_short1.yaml:9:          min_clients    : 101
cap2/rtsp_short1_slow.yaml:9:          min_clients    : 101
cap2/sip_short1.yaml:9:          min_clients    : 101
cap2/dns.yaml:9:          min_clients    : 101
cap2/imix_9k_burst_10.yaml:12:          min_clients    : 101
cap2/ipv6.yaml:9:          min_clients    : 101
cap2/http_plugin.yaml:9:          min_clients    : 101
cap2/sfr_agg_tcp14_udp11_http200msec_new_high_new_nir_profile_ipg_mix.yaml:9:          min_clients    : 101
cap2/dns_wlength.yaml:9:          min_clients    : 101
cap2/limit_single_pkt.yaml:12:          min_clients    : 101
cap2/rtsp_short2.yaml:9:          min_clients    : 101
cap2/tuple_gen.yaml:7:  min_clients    : 101

$ grep -rins clients_per_gb *
automation/trex_control_plane/client_utils/trex_yaml_gen.py:17:                                    'clients_per_gb': 201,
automation/regression/cfg/imix.yaml:12:          clients_per_gb : 201
automation/regression/cfg/imix_fast_1g.yaml:13:          clients_per_gb : 201
avl/sfr_delay_10_1g_asa_nat.yaml:8:          clients_per_gb : 201
avl/sfr_delay_10_1g.yaml:8:          clients_per_gb : 201
avl/sfr_delay_10_1g_no_bundeling.yaml:8:          clients_per_gb : 201
avl/sfr_branch_profile_delay_10.yaml:8:          clients_per_gb : 201
avl/sfr_delay_10_no_bundeling.yaml:8:          clients_per_gb : 201
avl/sfr_delay_50_tunnel_no_bundeling.yaml:8:          clients_per_gb : 201
avl/sfr_delay_10.yaml:8:          clients_per_gb : 201
cap2/cur_flow.yaml:8:          clients_per_gb : 201
cap2/cur_flow_single_tw_8.yaml:8:          clients_per_gb : 201
cap2/http_very_long.yaml:8:          clients_per_gb : 201
cap2/lb_ex1.yaml:8:          clients_per_gb : 201
cap2/per_template_gen4.yaml:8:          clients_per_gb : 201
cap2/per_template_gen5.yaml:8:          clients_per_gb : 201
cap2/rtsp.yaml:8:          clients_per_gb : 201
cap2/per_template_gen3.yaml:8:          clients_per_gb : 201
cap2/per_template_gen1.yaml:8:          clients_per_gb : 201
cap2/http.yaml:8:          clients_per_gb : 201
cap2/test_pcap_mode2.yaml:8:          clients_per_gb : 201
cap2/ipv6_load_balance.yaml:8:          clients_per_gb : 201
cap2/dns_single_server.yaml:8:          clients_per_gb : 201
cap2/dns_wlen.yaml:8:          clients_per_gb : 201
cap2/sip_short2.yaml:8:          clients_per_gb : 201
cap2/short_tcp.yaml:8:          clients_per_gb : 201
cap2/rtsp_full2.yaml:8:          clients_per_gb : 201
cap2/imix_9k.yaml:11:          clients_per_gb : 201
cap2/rtsp_short3.yaml:8:          clients_per_gb : 201
cap2/cur_flow_single.yaml:8:          clients_per_gb : 201
cap2/imix_64.yaml:11:          clients_per_gb : 201
cap2/imix_64_100k.yaml:11:          clients_per_gb : 201
cap2/http_simple_ipv6.yaml:8:          clients_per_gb : 201
cap2/asa_explot1.yaml:8:          clients_per_gb : 201
cap2/imix_64_fast.yaml:11:          clients_per_gb : 201
cap2/many_client_example.yaml:8:          clients_per_gb : 201
cap2/sfr2.yaml:8:          clients_per_gb : 201
cap2/http_simple.yaml:8:          clients_per_gb : 201
cap2/dns_wlen1.yaml:8:          clients_per_gb : 201
cap2/wrong_ip.yaml:8:          clients_per_gb : 201
cap2/dns_one_server.yaml:8:          clients_per_gb : 201
cap2/sfr3.yaml:8:          clients_per_gb : 201
cap2/test_pcap_mode1.yaml:8:          clients_per_gb : 201
cap2/dyn_pyld1.yaml:8:          clients_per_gb : 201
cap2/imix_1518.yaml:11:          clients_per_gb : 201
cap2/per_template_gen2.yaml:8:          clients_per_gb : 201
cap2/http_short.yaml:8:          clients_per_gb : 201
cap2/dns_wlen2.yaml:8:          clients_per_gb : 201
cap2/jumbo.yaml:8:          clients_per_gb : 201
cap2/limit_multi_pkt.yaml:11:          clients_per_gb : 201
cap2/ipv4_load_balance.yaml:8:          clients_per_gb : 201
cap2/nat_test.yaml:9:          clients_per_gb : 201
cap2/sfr.yaml:8:          clients_per_gb : 201
cap2/dns_tw.yaml:8:          clients_per_gb : 201
cap2/sfr4.yaml:8:          clients_per_gb : 201
cap2/dns_no_delay.yaml:8:          clients_per_gb : 201
cap2/rtsp_short1.yaml:8:          clients_per_gb : 201
cap2/rtsp_short1_slow.yaml:8:          clients_per_gb : 201
cap2/sip_short1.yaml:8:          clients_per_gb : 201
cap2/dns.yaml:8:          clients_per_gb : 201
cap2/imix_9k_burst_10.yaml:11:          clients_per_gb : 201
cap2/ipv6.yaml:8:          clients_per_gb : 201
cap2/http_plugin.yaml:8:          clients_per_gb : 201
cap2/sfr_agg_tcp14_udp11_http200msec_new_high_new_nir_profile_ipg_mix.yaml:8:          clients_per_gb : 201
cap2/dns_wlength.yaml:8:          clients_per_gb : 201
cap2/limit_single_pkt.yaml:11:          clients_per_gb : 201
cap2/rtsp_short2.yaml:8:          clients_per_gb : 201
cap2/tuple_gen.yaml:6:  clients_per_gb : 201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants