Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/tls.c file comment error #212

Closed
Applenice opened this issue Nov 28, 2018 · 1 comment
Closed

src/tls.c file comment error #212

Applenice opened this issue Nov 28, 2018 · 1 comment

Comments

@Applenice
Copy link

Applenice commented Nov 28, 2018

Hello,I saw these codes and comments while reading tls.c

/*
 * The maxiumum allowed length of a serial number is 20 octets
 * according to RFC5290 section 4.1.2.2. We give some leeway
 * for any non-conforming certificates.
 */
#define MAX_CERT_SERIAL_LENGTH 24
#define MAX_HANDSHAKE_LENGTH 11000

The comments in the section mentioned RFC 5290, but I reviewed RFC 5290 and found no relevant content.I checked the relevant information, which appeared in RFC 5280 section 4.1.2.2.

Given the uniqueness requirements above, serial numbers can be
expected to contain long integers. Certificate users MUST be able to
handle serialNumber values up to 20 octets. Conforming CAs MUST NOT
use serialNumber values longer than 20 octets.

Please check if the comments in this place are correct. Thank you.

@bhudson33
Copy link
Contributor

you are correct. the comment should say 5280 not 5290. I will correct this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants