New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs crypto_policy_* -> srtp_crypto_policy_* #457
Conversation
Just a doc change! I am also writing a benchmark to compare protection profile performance (to encourage AEAD GCM usage in WebRTC). Does anyone have any existing numbers (or programs) to quickly compare! I am hoping that the hw-acceleration from using OpenSSL makes a significant improvement :) thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I have approved it but will leave it unmerged for a bit in case others would like to reply to your questions. Personal I do not have any numbers on hand. But it would be interesting if you find some thing.
README.md
Outdated
@@ -138,16 +138,16 @@ can also be linked together to form an entire session policy. A linked | |||
list of `srtp_policy_t` structures is equivalent to a session policy. | |||
In such a policy, we refer to a single `srtp_policy_t` as an *element*. | |||
|
|||
An `srtp_policy_t` strucutre contains two `crypto_policy_t` structures | |||
An `srtp_policy_t` strucutre contains two `srtp_crypto_policy_t` structures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also change the typo here, while you're at it? strucutre
-> structure
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
@pabuhler I did! Here are my results
Hopefully the test isn't bad either, just pulled it together quickly. https://gist.github.com/Sean-Der/7a42bd70edfe1324ccc6ab399d653c0e If you are interested the conversation is happening on rtcweb now, would love your input/support there if interested :) |
@Sean-Der interesting numbers. The only thing I would do different is to use aes_cm_128_hmac_sha1_80 instead of aes_cm_128_hmac_sha1_32 as I feel that is the most common cm cipher in use and then try with data packets of 1024 bytes to see if that makes a different. |
No description provided.