Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json has git dependencies #58

Closed
micovery opened this issue Jun 1, 2016 · 0 comments
Closed

package.json has git dependencies #58

micovery opened this issue Jun 1, 2016 · 0 comments

Comments

@micovery
Copy link

micovery commented Jun 1, 2016 •
edited
Loading 

    "jsbn": "git+https://github.com/andyperlitch/jsbn.git",
    "node-forge": "git+https://github.com/linuxwolf/forge.git#master",
    "urlsafe-base64": "git+https://github.com/linuxwolf/urlsafe-base64.git#encoding"

This is not ideal for systems that don't have git installed ... you won't be able to npm install node-jose
Also, makes it harder to get get a reproducible build since the underlying node modules could change anytime under the hood ... or worse, the git repos could just go away.

Can these dependencies be changed so they are pulled from the NPM repos instead? Thanks.
@linuxwolf linuxwolf mentioned this issue Jul 5, 2016
Merged
linuxwolf added a commit that referenced this issue Jul 11, 2016
@linuxwolf
Build: reconcile git-prefixed dependencies
2b6bd1e 
Fixes #58, although it fixes this by using github releases for some dependencies (which haven't changed in a very very long time).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@micovery