-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better react and react-native compatibility #284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
It looks just about ready to go. I have a couple of things I'd like you to check, and one change to back out for now (we'll take care of it in a follow-up PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the changes. I'm happy to merge as-is, but will finish this tomorrow morning (Americas) to give time for last-minute changes.
Hi @linuxwolf , I don't have any other changes for this PR for now. However, after more testing in I would like to help address that separately, and have created another PR for that. |
Hi maintainers,
I'm trying to integrate this library into my react and react-native projects.
I believe, the following small changes will help:
buffer
dependency, and polyfill globalBuffer
process
dependency, and minimally polyfill globalprocess
browserify-zlib
dependency for browser type environmentreact-zlib-js
dependency for react-native type environment