Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better react and react-native compatibility #284

Merged
merged 9 commits into from
Mar 26, 2020

Conversation

ragibkl
Copy link
Contributor

@ragibkl ragibkl commented Mar 25, 2020

Hi maintainers,

I'm trying to integrate this library into my react and react-native projects.
I believe, the following small changes will help:

  • add buffer dependency, and polyfill global Buffer
  • add process dependency, and minimally polyfill global process
  • add browserify-zlib dependency for browser type environment
  • add react-zlib-js dependency for react-native type environment

package.json Outdated Show resolved Hide resolved
Copy link
Member

@linuxwolf linuxwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

It looks just about ready to go. I have a couple of things I'd like you to check, and one change to back out for now (we'll take care of it in a follow-up PR).

package.json Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
@ragibkl ragibkl requested a review from linuxwolf March 25, 2020 16:42
lib/index.js Outdated Show resolved Hide resolved
Copy link
Member

@linuxwolf linuxwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes. I'm happy to merge as-is, but will finish this tomorrow morning (Americas) to give time for last-minute changes.

@ragibkl
Copy link
Contributor Author

ragibkl commented Mar 26, 2020

Hi @linuxwolf ,

I don't have any other changes for this PR for now. However, after more testing in react-native, I realised that I was getting invalid results.

I would like to help address that separately, and have created another PR for that.

@linuxwolf linuxwolf merged commit 8126622 into cisco:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants