Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build with MS VS 2010 Express #5

Closed
ghost opened this issue Dec 9, 2013 · 4 comments
Closed

Cannot build with MS VS 2010 Express #5

ghost opened this issue Dec 9, 2013 · 4 comments

Comments

@ghost
Copy link

ghost commented Dec 9, 2013

I just tried "AutoBuild_Windows_VS2010.bat" but it couldn't find afxres.h and winres.h, I think they're both part of MFC Library but this is not included in Windows SDK 7 and MS VS 2010 Express as far as I know, is it impossible to compile the encoder binary if I don't have MFC? I tried using windows.h instead but it didn't help, it returns "LINK : fatal error LNK1123: failure during conversion to COFF: file invalid or corrupt".

@ethanhugg
Copy link
Contributor

You're right. Visual Studio Express versions do not come with the MFC/ATL headers. We should try to remove this dependency since it should not be needed.

Please try removing the .rc files (welsenc.rc, welsdec.rc, welsVP.rc) from your Visual Studio project and see if that removes this dependency. Thanks.

@ghost
Copy link
Author

ghost commented Dec 9, 2013

It worked like a charm! both decConsole.exe and encConsole.exe were compiled. Shell output:
http://paste.ofcode.org/3a8XHxeveAe46X9HNsAjBxq

It still returned the LNK1123 problem though, but it might be something wrong on my side, last time that I tried to compile anything with VS2010 Express was months ago, I guess something got messed somehow during this time, maybe I just need a fresh reinstall solved: #5 (comment).

@ethanhugg
Copy link
Contributor

Thanks for helping us debug this. I'll make sure this dep is removed when we move these builds to gyp.

@ghost
Copy link
Author

ghost commented Dec 10, 2013

You're welcome, I'll try to compile the debug version later (this was the release, I forgot to mention), that seems to be the problem.


"Error 'LINK : fatal error LNK1123" - Problem Fixed!
To get the run the debug, incremental linking must be turned off (or just rename cvtres.exe) in all project files (source: http://bit.ly/IZolkV). This is the content of the debug output folder:

10/12/2013  02:10         4.918.272 decConsole.bsc
10/12/2013  02:10            44.032 decConsole.exe
10/12/2013  02:10           822.272 decConsoled.pdb
10/12/2013  02:09            58.880 encConsole.exe
10/12/2013  02:09           805.888 encConsole.pdb
10/12/2013  02:10         1.036.176 welsdcore.lib
10/12/2013  02:10           201.728 welsdec.dll
10/12/2013  02:10               919 welsdec.exp
10/12/2013  02:10             1.924 welsdec.lib
10/12/2013  02:10           904.192 welsdec.pdb
10/12/2013  02:09           351.232 welsenc.dll
10/12/2013  02:09               935 welsenc.exp
10/12/2013  02:09             1.954 welsenc.lib
10/12/2013  02:09         1.231.872 welsenc.pdb
10/12/2013  02:09           393.728 welsvp.dll
10/12/2013  02:09               999 welsvp.exp
10/12/2013  02:09             1.518 welsvp.lib
10/12/2013  02:09           284.042 welsvp.map
10/12/2013  02:09         2.042.880 welsvp.pdb

It's missing the encoder/decoder binary files, probably need to open a new issue about that.

@ghost ghost mentioned this issue Dec 10, 2013
shihuade referenced this issue in shihuade/openh264 Jul 25, 2016
[Encoder] add interface for new SpsPpsIdStrategy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant