Fix glitches that sometimes happen near the scene changes. #3707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CWelsDecoder::ReorderPicturesInDisplay(), iLastWrittenPOC was not set in unbuffered-reordering case. Due to this problem, it sometimes reordered the frames incorrectly. This patch fixes the issue.
When bNewSeqBegin got true, iRefCount was forcibly reset even if the buffer was still used for reordering. Due to this problem, the buffer in use was sometimes overwritten with newly decoded frame. This commit is for fixing that problem.
|
If it is better to provide sample video file with the glitch, I am ready to do that. |
|
Please reproduce the glitch (2) using the sample video file: The glitch will occur at about 12 sec. point from the begining. |
This was referenced Dec 8, 2023
Closed
tyan0
changed the title
|
@tyan0 CI failed. |
|
Thanks for checking. I have fixed that problem. Could you please rerun CI? |
tyan0
force-pushed
the
master
branch
4 times, most recently
from
f82abc0
to
c947a4c
Compare
|
I revised the pull request several times. Now I am almost sure that this is the final change. Please review. Thanks. |
|
I found another problem of the current openh264 code regarding scene change.
This causes when multiple scene canges happen in a very short time. I would like to add new commit for that problem. |
|
Done. Please review. |
Previously, when more than 2 frame sequences exist in the reordering buffer, the reordering does not work correctly. This is because the management based on bLastGOP flag does not work in this case. Instead, this patch introduces frame sequence number (iSeqNum) to distingish frames belonging to each sequence and drops bLastGOP flag.
|
Fix typo in commit message. |
|
Thanks for the fix @tyan0 |
|
Thanks! |
This was referenced Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the first time I used the openh264 decoder, I have encountered glitches that sometimes happen near the scene changes. I looked into this problem and found two causes.
This issue happens frequently enough to frustrate me. I wonder why the other users have not pointed this problem out till today.
This pull request provides two commits corresponding to each problem.