-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualize thresholds when plotting MetricValueWithThresholds #38
Comments
@kennysong Hi Song, I'm trying to add code for this feature now, but before I complete it, I want to ask is there any plan to support more Filter Syntax in the future?
I think it is also a new feature that can be added. |
Hi @Vela-zz, thanks for the PR! I don't think we're planning to support those multi-condition thresholds right now, so we can keep your PR focused on the existing binary threshold case. If you're looking for other issues to work on, happy to chat more on Discord! |
When plotting a MetricValueWithThreshold value like
(toxicity_values > 0.5).scatter()
, we should draw a vertical line in the chart where the threshold is.We could do this for the double scatter plot (
langcheck.plot.scatter(toxicity_values > 0.5, sentiment_values > 0.5)
) and the histogram as well ((toxicity_values > 0.5).histogram()
).The text was updated successfully, but these errors were encountered: