Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize thresholds when plotting MetricValueWithThresholds #38

Closed
kennysong opened this issue Nov 3, 2023 · 2 comments
Closed

Visualize thresholds when plotting MetricValueWithThresholds #38

kennysong opened this issue Nov 3, 2023 · 2 comments

Comments

@kennysong
Copy link
Contributor

When plotting a MetricValueWithThreshold value like (toxicity_values > 0.5).scatter(), we should draw a vertical line in the chart where the threshold is.

We could do this for the double scatter plot (langcheck.plot.scatter(toxicity_values > 0.5, sentiment_values > 0.5)) and the histogram as well ((toxicity_values > 0.5).histogram()).

@Vela-zz
Copy link
Contributor

Vela-zz commented Nov 3, 2023

@kennysong Hi Song, I'm trying to add code for this feature now, but before I complete it, I want to ask is there any plan to support more Filter Syntax in the future?

toxicity_values > 0.5 and toxicity_values < 0.7
#
toxicity_values < 0.3 | toxicity_values > 0.7

I think it is also a new feature that can be added.

@kennysong
Copy link
Contributor Author

Hi @Vela-zz, thanks for the PR! I don't think we're planning to support those multi-condition thresholds right now, so we can keep your PR focused on the existing binary threshold case.

If you're looking for other issues to work on, happy to chat more on Discord!

cc @yosukehigashi

Alnusjaponica pushed a commit to Alnusjaponica/langcheck that referenced this issue Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants