Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix convert support chinese #170

Merged
merged 1 commit into from Apr 10, 2020
Merged

fix convert support chinese #170

merged 1 commit into from Apr 10, 2020

Conversation

UDLD
Copy link
Contributor

@UDLD UDLD commented Apr 7, 2020

No description provided.

@UDLD UDLD changed the title fix convert support china fix convert support chinese Apr 8, 2020
Copy link
Member

@rainchen rainchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented

@UDLD
Copy link
Contributor Author

UDLD commented Apr 9, 2020

@rainchen add chinese case done

@codecov-io
Copy link

Codecov Report

Merging #170 into develop will increase coverage by 11.88%.
The diff coverage is 68.38%.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop     #170       +/-   ##
==============================================
+ Coverage      22.14%   34.03%   +11.88%     
- Complexity       900     1074      +174     
==============================================
  Files            197      173       -24     
  Lines          12204    10568     -1636     
  Branches        1690     1616       -74     
==============================================
+ Hits            2703     3597      +894     
+ Misses          9258     6643     -2615     
- Partials         243      328       +85     
Impacted Files Coverage Δ Complexity Δ
...ava/com/citahub/cita/abi/TypeMappingException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...com/citahub/cita/abi/datatypes/UnorderedEvent.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...java/com/citahub/cita/abi/datatypes/BytesType.java 47.05% <47.05%> (ø) 4.00 <4.00> (?)
...ain/java/com/citahub/cita/abi/datatypes/Array.java 48.38% <48.38%> (ø) 8.00 <8.00> (?)
...ain/java/com/citahub/cita/abi/datatypes/Bytes.java 50.00% <50.00%> (ø) 2.00 <2.00> (?)
...va/com/citahub/cita/abi/datatypes/NumericType.java 52.94% <52.94%> (ø) 5.00 <5.00> (?)
...main/java/com/citahub/cita/abi/datatypes/Bool.java 53.84% <53.84%> (ø) 5.00 <5.00> (?)
...ain/java/com/citahub/cita/abi/datatypes/Fixed.java 55.55% <55.55%> (ø) 3.00 <3.00> (?)
...c/main/java/com/citahub/cita/abi/EventEncoder.java 57.14% <57.14%> (ø) 5.00 <5.00> (?)
...com/citahub/cita/abi/datatypes/FixedPointType.java 57.14% <57.14%> (ø) 6.00 <6.00> (?)
... and 360 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 078689a...95808c2. Read the comment docs.

Copy link
Collaborator

@yangzhenlong yangzhenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the title china should be chinese

@UDLD UDLD merged commit bd5ce84 into develop Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants