Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate entity.orcid #328

Closed
sdruskat opened this issue Aug 26, 2021 · 4 comments
Closed

Deprecate entity.orcid #328

sdruskat opened this issue Aug 26, 2021 · 4 comments
Assignees
Labels
bug deprecation Schema elements that may be deprecated
Milestone

Comments

@sdruskat
Copy link
Member

sdruskat commented Aug 26, 2021

I can actually see no case for an entity having an ORCID id, unless the entity hacks ORCID.
I believe that this is a bug, which should be fixed.

It could be replaced by ROR or FundRef ID, but perhaps websites are the best identifiers for orgs, and they're already possible to supply.

Doesn't need a "hotfix", as no one will use the key because there cannot be an entity ORCID.

@sdruskat sdruskat added the bug label Aug 26, 2021
@sdruskat sdruskat added this to the 2.0.0 milestone Aug 26, 2021
@jspaaks jspaaks added the deprecation Schema elements that may be deprecated label Oct 4, 2023
@sdruskat
Copy link
Member Author

@jspaaks I would consider removing entity.orcid for 1.3.0 as a bugfix similar to the changes in #462. And change the milestone to 1.3.0 as well.

I'm also in favour of supporting ROR instead as part of this work, as it has emerged as the community standard for identifying organizations over the last few years. See, e.g., https://ror.org/04bwf3e34 and https://ror.org/00rbjv475.

What do you think?

@jspaaks
Copy link
Member

jspaaks commented Oct 23, 2023

  1. I'm OK with removing orcid from entity as a bugfix, especially because you mentioned one can't really get an ORCID account for a group, right?
  2. spawned Consider adding ROR as identifier for entities #480 to facilitate the discussion regarding RORs

@jspaaks
Copy link
Member

jspaaks commented Jan 23, 2024

FWIW entity has ror now, but also still has orcid. Should we remove it before releasing 1.3.0?

"orcid": {
"$ref": "#/$defs/orcid",
"description": "The entity's orcid."
},

@jspaaks jspaaks modified the milestones: 2.0.0, 1.3.0 Jan 23, 2024
@jspaaks jspaaks self-assigned this Feb 3, 2024
@jspaaks jspaaks mentioned this issue Feb 3, 2024
4 tasks
@sdruskat
Copy link
Member Author

Closing as resolved in #522.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug deprecation Schema elements that may be deprecated
Projects
None yet
Development

No branches or pull requests

2 participants