Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong "is instance" for preprint #136

Closed
Tracked by #160
fnielsen opened this issue Nov 18, 2021 · 7 comments
Closed
Tracked by #160

Wrong "is instance" for preprint #136

fnielsen opened this issue Nov 18, 2021 · 7 comments
Labels
category: mapping Parsers and formatters package: core package: plugin-doi type: bug Something isn't working

Comments

@fnielsen
Copy link

For instance, https://www.medrxiv.org/content/10.1101/2021.08.15.21262067 results in manuscript (document written by hand). https://www.wikidata.org/w/index.php?title=Q109622851&oldid=1529788551

I would have expected that is should be something else, e.g., preprint.

@fnielsen
Copy link
Author

I forgot to check whether this is already fixed. We are seeing the error in Scholia WDscholia/scholia#1704

@fnielsen
Copy link
Author

Current master:

$ citation-js -t https://doi.org/10.1101/2021.07.28.21261159 | python -m json.tool | grep '"type"'
        "type": "manuscript",
                "type": "@doi/api",
                "type": "@csl/list+object"

@larsgw
Copy link
Member

larsgw commented Nov 18, 2021

The CrossRef API is (still!) returning invalid CSL-JSON. They are using the type "posted-content" (should be "article") with the subtype field (undocumented, they should use genre) set to "preprint". At the time it was a bit unclear what "posted-content" should be matched to, and I used this mapping. I'm still not sure if I can always map "posted-content" to "article", who knows what other subtypes there might be.

@larsgw larsgw added package: core package: plugin-doi category: mapping Parsers and formatters type: bug Something isn't working labels Nov 18, 2021
@fnielsen
Copy link
Author

Would this be better: https://www.wikidata.org/wiki/Q2376293. It is also call a "manuscript".

@larsgw
Copy link
Member

larsgw commented Nov 18, 2021

The CSL documentation says this about manuscript

An unpublished manuscript; Use for both modern unpublished works and classical manuscripts; For working papers, preprints, and similar works posted to a repository, use article.

So I think the issue lies more with the CrossRef data. I can make a workaround in Citation.js, though I'd prefer CrossRef fixed their API of course.

By the way, the mappings to Wikidata are based on the exact match (P2888) statements (query)

@fnielsen
Copy link
Author

fnielsen commented Nov 18, 2021

In Scholia we got manuscript: 'Q87167'

This should/could be manuscript: 'Q2376293',.

I am not immediately able to see where that line comes from in the citation-js code

larsgw added a commit that referenced this issue Nov 23, 2021
@larsgw larsgw mentioned this issue May 20, 2022
17 tasks
@larsgw
Copy link
Member

larsgw commented May 20, 2022

This seems to be fixed in v0.5.3, not sure why I kept it open.

@larsgw larsgw closed this as completed May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: mapping Parsers and formatters package: core package: plugin-doi type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants