Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update locale fallback table. Fix #48 #56

Conversation

customcommander
Copy link
Contributor

@customcommander customcommander commented Jul 29, 2018

Ping @rmzelle, @adam3smith :-)

@customcommander
Copy link
Contributor Author

👋
@rmzelle @fbennett ?

@customcommander
Copy link
Contributor Author

@rmzelle @adam3smith Morning guys, is this the correct repo or shall I open a PR in another one? ☺️

@rmzelle
Copy link
Member

rmzelle commented Sep 3, 2018

@adam3smith, happy with my changes? I figured it would be a little clearer if I added the language/locale descriptions to the locale codes.

It makes it a little bit harder to parse down for implementers, but if that's a concern we'd be better off providing a parsable file separate from the specification (e.g. in JSON).

@rmzelle
Copy link
Member

rmzelle commented Sep 3, 2018

@rmzelle @adam3smith Morning guys, is this the correct repo or shall I open a PR in another one?

No, this is the right place. We're just very slow.

@adam3smith adam3smith merged commit da6d664 into citation-style-language:master Sep 4, 2018
@adam3smith
Copy link
Member

Thanks, looks good!

@rmzelle
Copy link
Member

rmzelle commented Sep 6, 2018

Thanks, looks good!

@adam3smith, I set up an organization-wide project, by the way, to track which pull requests should receive a mention in the change log of the next CSL release: https://github.com/orgs/citation-style-language/projects/1. We can pull in zotero-bits issues as we address them.

@customcommander
Copy link
Contributor Author

@rmzelle @adam3smith It doesn't seem that the locales fallback table has been updated/deployed. I'm happy to help but I presume this would require access to some private publishing tools.

The doc as of now:

screen shot 2019-01-11 at 13 58 09

@rmzelle
Copy link
Member

rmzelle commented Jan 12, 2019

It doesn't seem that the locales fallback table has been updated/deployed.

You're looking at the "1.0.1" branch. See https://docs.citationstyles.org/en/master/specification.html#locale-fallback for the updated version. I rather not backport this change to CSL 1.0.1.

@customcommander
Copy link
Contributor Author

Ohh I see. I didn't even notice that! Ok fine by me. Thanks ;)

@customcommander customcommander deleted the update-fallback-table branch January 12, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants