New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update locale fallback table. Fix #48 #56
Update locale fallback table. Fix #48 #56
Conversation
@rmzelle @adam3smith Morning guys, is this the correct repo or shall I open a PR in another one? |
@adam3smith, happy with my changes? I figured it would be a little clearer if I added the language/locale descriptions to the locale codes. It makes it a little bit harder to parse down for implementers, but if that's a concern we'd be better off providing a parsable file separate from the specification (e.g. in JSON). |
No, this is the right place. We're just very slow. |
Thanks, looks good! |
@adam3smith, I set up an organization-wide project, by the way, to track which pull requests should receive a mention in the change log of the next CSL release: https://github.com/orgs/citation-style-language/projects/1. We can pull in zotero-bits issues as we address them. |
@rmzelle @adam3smith It doesn't seem that the locales fallback table has been updated/deployed. I'm happy to help but I presume this would require access to some private publishing tools. The doc as of now: |
You're looking at the "1.0.1" branch. See https://docs.citationstyles.org/en/master/specification.html#locale-fallback for the updated version. I rather not backport this change to CSL 1.0.1. |
Ohh I see. I didn't even notice that! Ok fine by me. Thanks ;) |
Ping @rmzelle, @adam3smith :-)