CMoS: fix the delimiter before journal pages (discourse1846) (#7042)

citation-style-language · May 12, 2024 · 434df0a · 434df0a
1 parent a056170
commit 434df0a
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 6 deletions.
diff --git a/chicago-author-date-no-em-dash.csl b/chicago-author-date-no-em-dash.csl
@@ -29,10 +29,14 @@
     <contributor>
       <name>Brenton M. Wiernik</name>
     </contributor>
+    <contributor>
+      <name>Zeping Lee</name>
+      <email>zepinglee@gmail.com</email>
+    </contributor>
     <category citation-format="author-date"/>
     <category field="generic-base"/>
     <summary>The author-date variant of the Chicago style</summary>
-    <updated>2024-04-09T10:33:15+00:00</updated>
+    <updated>2024-05-09T13:08:52+00:00</updated>
     <rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
   </info>
   <locale xml:lang="en">
@@ -385,8 +389,19 @@
       </if>
       <else-if type="article-journal">
         <choose>
-          <if variable="volume issue" match="any">
-            <text variable="page" prefix=": "/>
+          <if variable="volume">
+            <choose>
+              <if variable="issue">
+                <text variable="page" prefix=": "/>
+              </if>
+              <else>
+                <!-- CMoS 15.48: If the month or season is included, it is
+                  enclosed in parentheses, and a space follows the colon.
+                  Unfortunately we can't check the month in CSL v1.0.2.
+                -->
+                <text variable="page" prefix=":"/>
+              </else>
+            </choose>
           </if>
           <else>
             <text variable="page" prefix=", "/>

diff --git a/chicago-author-date.csl b/chicago-author-date.csl
@@ -29,10 +29,14 @@
     <contributor>
       <name>Brenton M. Wiernik</name>
     </contributor>
+    <contributor>
+      <name>Zeping Lee</name>
+      <email>zepinglee@gmail.com</email>
+    </contributor>
     <category citation-format="author-date"/>
     <category field="generic-base"/>
     <summary>The author-date variant of the Chicago style</summary>
-    <updated>2024-04-09T10:33:14+00:00</updated>
+    <updated>2024-05-09T13:08:37+00:00</updated>
     <rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
   </info>
   <locale xml:lang="en">
@@ -385,8 +389,19 @@
       </if>
       <else-if type="article-journal">
         <choose>
-          <if variable="volume issue" match="any">
-            <text variable="page" prefix=": "/>
+          <if variable="volume">
+            <choose>
+              <if variable="issue">
+                <text variable="page" prefix=": "/>
+              </if>
+              <else>
+                <!-- CMoS 15.48: If the month or season is included, it is
+                  enclosed in parentheses, and a space follows the colon.
+                  Unfortunately we can't check the month in CSL v1.0.2.
+                -->
+                <text variable="page" prefix=":"/>
+              </else>
+            </choose>
           </if>
           <else>
             <text variable="page" prefix=", "/>