-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor tweaks to a CSL I authored #691
Conversation
Changed default-locale to fr-CA (didn't exist when this csl was written)
@@ -213,7 +213,7 @@ | |||
</else-if> | |||
<else-if type="chapter paper-conference webpage" match="any"> | |||
<group prefix=" "> | |||
<text value="In" suffix=" : " text-case="capitalize-first"/> | |||
<text value="dans" suffix=" : " text-case="capitalize-first"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't matter that much, but you could use the "in" term here instead, like:
<text term="in" suffix=" : " text-case="capitalize-first"/>
This term is already set to "dans" by default for Canadian French (fr-CA), see https://github.com/citation-style-language/locales/blob/master/locales-fr-CA.xml#L42 . The benefit would be that if anybody wants to use this style as a template for a France French (fr-FR) style and changes the value of "default-locale", that the "dans" would automatically change to "in" (as is customary in fr-FR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I understand the use of locales.
But for some reason, it does not seem to work with Mendeley... So I hard coded every instance where needed, like here:
Mendeley also outputs month names in English when there is a URL in my reference for which I need to give the date accessed.
I have not found the way around that...
Thanks for all your work on CSLs! :)
JH Roy
Montreal
Le 2013-09-06 à 14:24, Rintze M. Zelle a écrit :
In universite-laval-departement-dinformation-et-de-communication.csl:
@@ -213,7 +213,7 @@
<text value="In" suffix=" : " text-case="capitalize-first"/>
It doesn't matter that much, but you could use the "in" term here instead, like:<text value="dans" suffix=" : " text-case="capitalize-first"/>
This term is already set to "dans" by default for Canadian French (fr-CA), see https://github.com/citation-style-language/locales/blob/master/locales-fr-CA.xml#L42 . The benefit would be that if anybody wants to use this style as a template for a France French (fr-FR) style and changes the value of "default-locale", that the "dans" would automatically change to "in" (as is customary in fr-FR).
—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you report that problem to them? That really seems like a bug on their end.
I'll accept the style as is, then. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and when doing so, please refer to https://github.com/citation-style-language/styles/pull/691/files#r6215555 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I'll do that!
Thanks for everything! :)
JHR
Le 2013-09-06 à 15:12, Rintze M. Zelle a écrit :
In universite-laval-departement-dinformation-et-de-communication.csl:
@@ -213,7 +213,7 @@
<text value="In" suffix=" : " text-case="capitalize-first"/>
Could you report that problem to them? That really seems like a bug on their end.<text value="dans" suffix=" : " text-case="capitalize-first"/>
I'll accept the style as is, then. Thanks!
—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Just a follow up on the bug I reported earlier today.
I resolved it by changing a JavaScript file (loadlocale.js) file in Mendeley's bundle.
Not an elegant solution. I know.
Thanks again and congrats for all your great work! :)
JH Roy
Le 2013-09-06 à 15:12, Rintze M. Zelle a écrit :
In universite-laval-departement-dinformation-et-de-communication.csl:
@@ -213,7 +213,7 @@
<text value="In" suffix=" : " text-case="capitalize-first"/>
Could you report that problem to them? That really seems like a bug on their end.<text value="dans" suffix=" : " text-case="capitalize-first"/>
I'll accept the style as is, then. Thanks!
—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you still report it to Mendeley? Were you able to discover what causes the bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I did post on their support section.
Jean-Hugues Roy
jh@jhroy.ca
514/778-6102
Le 2013-09-06 à 18:32, "Rintze M. Zelle" notifications@github.com a écrit :
In universite-laval-departement-dinformation-et-de-communication.csl:
@@ -213,7 +213,7 @@
<text value="In" suffix=" : " text-case="capitalize-first"/>
Will you still report it to Mendeley? Were you able to discover what causes the bug?<text value="dans" suffix=" : " text-case="capitalize-first"/>
—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tweaks to a CSL I authored
Thanks for the other improvements adam3smith and rmzelle have brought to this CSL! :)