Created new style review-of-international-studies.csl #2362
Conversation
|
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.
If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
|
😃 Your submission passed all our automated tests. |
There was a problem hiding this comment.
I started doing a regular review, but looking at the styleguide, this seems to be the wrong "type" of style. The Review uses notes (i.e. class="note") not parentheticals in text and those notes should have the full bibliographic information, not just author date. And then there's no bibliography. You could either try moving what you have for the bibliography up to the citation section or start from a different style like MHRA, which has the right structure in place (you'll also need to implement a shortened subsequent note, which MHRA already does.)
Let me know if that makes sense.
| </group> | ||
| </layout> | ||
| </citation> | ||
| <bibliography hanging-indent="true" et-al-min="6" et-al-use-first="6"> |
There was a problem hiding this comment.
You want the et-al-min to always be at least one higher than the et-al-use-first. Zotero may be doing this right in spite of this, but what you're literally saying is "for 6 authors, print the first 6 followed by et al" which doesn't make sense.
| <group delimiter=", " suffix="."> | ||
| <names variable="editor translator" delimiter=", "> | ||
| <name and="symbol" sort-separator=", " initialize-with=". "/> | ||
| <label form="short" prefix=" (" suffix=")" text-case="capitalize-first"/> |
There was a problem hiding this comment.
It seems odd that the editor label would appear as (ed.) for book chapters, but as , Ed. (as per the editor translator macro) otherwise. Could you check on that and unify as needed? Ideally, I'd like you to reuse the macro here (which may require adjusting it, in particular taking out the parenthesis around the whole thing there).
| <date variable="issued" prefix=" (" suffix=")"> | ||
| <date-part name="year"/> | ||
| </date> | ||
| <group prefix=", "> |
There was a problem hiding this comment.
pretty sure that will give you the page ranges twice for chapters, here and on line 129 above. Could you check on that?
| <substitute> | ||
| <names variable="editor"/> | ||
| <names variable="translator"/> | ||
| <choose> |
There was a problem hiding this comment.
the substitute for author and author-short should almost certainly correspond. If you're putting in the container-title here but use the title or short-title in the text, how is a reader going to find this in the bibliography?
thanks to it being pointed out by adam3smith
|
😃 Your submission passed all our automated tests. |
|
@damnation333, I see you made some minor changes, but the main issue is that this should be a "note" CSL style, not an "author-date" one. |
|
Closed as complete style needs reworking to be a note style and not author-date style. Bibliographic parts would still work. |
No description provided.