Minor change to ENS de Lyon style #2452
Conversation
I've changed the bibliography layout (indent and entry spacing)
|
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.
If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
|
😟 There are some issues with your submission. Please check the test report for details. |
|
😟 There are some issues with your submission. Please check the test report for details. |
|
😃 Your submission passed all our automated tests. |
Adding new category fields.
|
😃 Your submission passed all our automated tests. |
| @@ -657,7 +663,7 @@ | |||
| </layout> | |||
| </citation> | |||
| <!--_-_-_-_-_-SECTION DEFINITION DE LA BIBLIO (bibliography)-_-_-_-_-_-_--> | |||
| <bibliography> | |||
| <bibliography hanging-indent="true" entry-spacing="2"> | |||
There was a problem hiding this comment.
are you sure about entry-spacing="2"? That's two (!) line breaks between entries.
Entry 1
Entry 2
| <category field="history"/> | ||
| <category field="humanities"/> | ||
| <category field="political_science"/> | ||
| <category field="sociology"/> |
There was a problem hiding this comment.
this seems a bit excessive in terms of disciplines. Wouldn't social_science and humanities just cover this? Too many categories make this less useful as metadata
I've changed entry-spacing = 1 ; the disciplines in metadata correspond to our students' discipline I erased the template "Presses Universitaires de Rennes" because our style has been considerably changed and is no longer similar to the PUR
|
😃 Your submission passed all our automated tests. |
| <category field="history"/> | ||
| <category field="humanities"/> | ||
| <category field="political_science"/> | ||
| <category field="sociology"/> |
There was a problem hiding this comment.
@smarchand, this is still rather extreme, though. Could you please trim it back to 2-3 fields max? For comparison, of our 1435 independent CSL styles, just 5 have 4 fields assigned, and only one styles 5 fields. We currently have no styles with more assigned fields than that, while here you go all the way to 7.
In general, if a style can't be assigned to a select few fields, we assign it either no field at all or the "generic-base" field.
There was a problem hiding this comment.
The CSL fields are a bit unevenly spread over the different disciplines anyway. Generally it's much easier to just search for styles by name than to filter them by discipline.
I trimed category fields to 3 disciplines thanks !
|
😃 Your submission passed all our automated tests. |
|
😃 Your submission passed all our automated tests. |
|
Great, thanks. Sorry for being nitpicky. |
|
thanks to you !
Stéphane
2017-01-25 14:45 GMT+01:00 Rintze M. Zelle <notifications@github.com>:
… Great, thanks. Sorry for being nitpicky.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2452 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIsBv3WOwDSZBOj2TdeAJ5P9fjcvDmn6ks5rV1HvgaJpZM4LqxeA>
.
|
I've changed the bibliography layout (indent and entry spacing)