Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename dependent/asian-pacific-journal-of-tropical-disease… #2570

Merged
merged 4 commits into from Mar 23, 2017
Merged

Conversation

@csl-bot
Copy link

csl-bot commented Mar 16, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot
Copy link

csl-bot commented Mar 16, 2017

😃 Your submission passed all our automated tests.

<id>http://www.zotero.org/styles/asian-pacific-journal-of-tropical-disease</id>
<link href="http://www.zotero.org/styles/asian-pacific-journal-of-tropical-disease" rel="self"/>
<link href="http://www.zotero.org/styles/european-journal-of-human-genetics" rel="template"/>
<link href="http://www.elsevier.com/journals/asian-pacific-journal-of-tropical-medicine/1995-7645/guide-for-authors" rel="documentation"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "documentation" link is to a different journal ("Medicine", not "Disease").

https://www.journals.elsevier.com/asian-pacific-journal-of-tropical-disease/
https://www.journals.elsevier.com/asian-pacific-journal-of-tropical-medicine/

Are you sure they share the same format?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah man.... thanks for spotting that.
There is no guide for the APJTD actually then.
As an elsevier journal the APJTM should then have one of their house styles, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an elsevier journal the APJTM should then have one of their house styles, no?

Well, generally speaking yes, although there are exceptions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no guide for the APJTD actually then.

Per https://forums.zotero.org/discussion/comment/272296/#Comment_272296, there seems to be a guide for the journal at http://www.apjtcm.com/authors.html.

As discussed here: https://forums.zotero.org/discussion/comment/272491/#Comment_272491
hainan-medical-university-journal-publisher.csl becoming parent style with 8 dependents.
@csl-bot
Copy link

csl-bot commented Mar 22, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Mar 23, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Mar 23, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 3d1f719 into citation-style-language:master Mar 23, 2017
@rmzelle
Copy link
Member

rmzelle commented Mar 23, 2017

Thanks!

@rmzelle
Copy link
Member

rmzelle commented Mar 23, 2017

(@damnation333, you'll make a single PR for the rest of the journals?)

@POBrien333
Copy link
Contributor Author

Yes. Will do the rest now, since this one got signed off. I shall find out how to do one big PR. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants