Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update harvard-imperial-college-london.csl #2678

Merged
merged 2 commits into from May 10, 2017

Conversation

libora
Copy link
Contributor

@libora libora commented May 10, 2017

@csl-bot
Copy link

csl-bot commented May 10, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot
Copy link

csl-bot commented May 10, 2017

😃 Your submission passed all our automated tests.

@@ -143,9 +143,11 @@
</macro>
<citation et-al-min="4" et-al-use-first="3" disambiguate-add-year-suffix="true" collapse="year">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also have et-al-use-first="1". Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks

@csl-bot
Copy link

csl-bot commented May 10, 2017

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit 9b46f09 into citation-style-language:master May 10, 2017
@adam3smith
Copy link
Member

Great thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants