New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ib-tauris-note.csl #2979
Conversation
via https://forums.zotero.org/discussion/67382/style-request-ib-tauris#latest In their guidelines they also talk about a Harvard style, hence this is labelled Note.
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
😟 There are some issues with your submission. Please check the test report for details. |
😃 Your submission passed all our automated tests. |
😃 Your submission passed all our automated tests. |
😃 Your submission passed all our automated tests. |
1 similar comment
😃 Your submission passed all our automated tests. |
two quick comments; looks great otherwise. |
Uhmm, @adam3smith, where are those two comments? |
<text variable="container-title" font-style="italic"/> | ||
</macro> | ||
<macro name="editors"> | ||
<names variable="editor translator"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you'll want <name and="text"/>
here, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. Is there a word missing? Not getting it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, forgot the code tags
<text variable="locator"/> | ||
</group> | ||
</group> | ||
</if> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably add
<else-if position="ibid">
<text term="ibid"/>
</else-if>
(otherwise you'll get regular citations for ibid w/o locator, i.e. same item without a page number. Unless that's on purpose, in which case please disregard)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. added.
sorry about that; posted now. |
😃 Your submission passed all our automated tests. |
😟 There are some issues with your submission. Please check the test report for details. |
(the cs:names/cs:name construction isn't the most fortunate design decision in CSL -- see my just committed fix for how this should look) |
😃 Your submission passed all our automated tests. |
I should've maybe tested that before just adding random code. haha. my fault. |
@rmzelle good to merge from my end |
Here too. Just waiting on the forums to see if we use a better documentation link. |
😟 There are some issues with your submission. Please check the test report for details. |
😃 Your submission passed all our automated tests. |
This is ready now from my side :) |
Thanks! |
via https://forums.zotero.org/discussion/67382/style-request-ib-tauris
In their guidelines they also talk about a Harvard style, hence this is labelled Note.
Guidelines: IBT House Style 2016.pdf