Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ib-tauris-note.csl #2979

Merged
merged 10 commits into from Oct 6, 2017
Merged

Conversation

POBrien333
Copy link
Contributor

@POBrien333 POBrien333 commented Sep 25, 2017

via https://forums.zotero.org/discussion/67382/style-request-ib-tauris

In their guidelines they also talk about a Harvard style, hence this is labelled Note.

Guidelines: IBT House Style 2016.pdf

via https://forums.zotero.org/discussion/67382/style-request-ib-tauris#latest

In their guidelines they also talk about a Harvard style, hence this is labelled Note.
@csl-bot
Copy link

csl-bot commented Sep 25, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot
Copy link

csl-bot commented Sep 25, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Sep 25, 2017

😃 Your submission passed all our automated tests.

@csl-bot
Copy link

csl-bot commented Sep 25, 2017

😃 Your submission passed all our automated tests.

@csl-bot
Copy link

csl-bot commented Sep 25, 2017

😃 Your submission passed all our automated tests.

1 similar comment
@csl-bot
Copy link

csl-bot commented Sep 25, 2017

😃 Your submission passed all our automated tests.

@adam3smith
Copy link
Member

two quick comments; looks great otherwise.

@rmzelle
Copy link
Member

rmzelle commented Sep 26, 2017

Uhmm, @adam3smith, where are those two comments?

<text variable="container-title" font-style="italic"/>
</macro>
<macro name="editors">
<names variable="editor translator">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll want <name and="text"/> here, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. Is there a word missing? Not getting it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, forgot the code tags

<text variable="locator"/>
</group>
</group>
</if>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably add

<else-if position="ibid">
  <text term="ibid"/>
</else-if>

(otherwise you'll get regular citations for ibid w/o locator, i.e. same item without a page number. Unless that's on purpose, in which case please disregard)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. added.

@adam3smith
Copy link
Member

sorry about that; posted now.

@csl-bot
Copy link

csl-bot commented Sep 26, 2017

😃 Your submission passed all our automated tests.

@csl-bot
Copy link

csl-bot commented Sep 26, 2017

😟 There are some issues with your submission. Please check the test report for details.

@adam3smith
Copy link
Member

(the cs:names/cs:name construction isn't the most fortunate design decision in CSL -- see my just committed fix for how this should look)

@csl-bot
Copy link

csl-bot commented Sep 26, 2017

😃 Your submission passed all our automated tests.

@POBrien333
Copy link
Contributor Author

I should've maybe tested that before just adding random code. haha. my fault.

@adam3smith
Copy link
Member

@rmzelle good to merge from my end

@rmzelle
Copy link
Member

rmzelle commented Sep 26, 2017

Here too. Just waiting on the forums to see if we use a better documentation link.

@csl-bot
Copy link

csl-bot commented Oct 4, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Oct 4, 2017

😃 Your submission passed all our automated tests.

@POBrien333
Copy link
Contributor Author

This is ready now from my side :)

@rmzelle rmzelle merged commit 2e7b018 into citation-style-language:master Oct 6, 2017
@rmzelle
Copy link
Member

rmzelle commented Oct 6, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants