Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create The Design Journal #355

Closed
wants to merge 1 commit into from

Conversation

Chris210
Copy link

A Harvard style format for The Design Journal

A Harvard style format for The Design Journal
@adam3smith
Copy link
Member

Thank you, please see here: https://github.com/citation-style-language/styles/wiki/Style-Requirements and fix up the formal issues before we can merge this.

@adam3smith
Copy link
Member

@rmzelle @inukshuk - still, Travis is giving the green light to styles that shouldn't be merged. That's not good...

@rmzelle
Copy link
Member

rmzelle commented Jan 25, 2013

@adam3smith, the problem is that the added style doesn't have a ".csl" extension, and thus escapes detection. Not sure how to handle this since the repository contains a bunch of non-CSL style files. (ideally, Travis/github would offer some easy way to identify which files are added/removed by the pull request)

@rmzelle
Copy link
Member

rmzelle commented Jan 25, 2013

Added, thanks!

f669f05

@rmzelle rmzelle closed this Jan 25, 2013
@inukshuk
Copy link
Member

@rmzelle thanks for looking into this. What we could do is to use to select the styles by exclusion with the pattern. That is, we could simply adapt the pattern to mark the non-style files. This pattern would have to be adapted when we add new files to the repository, but this does not happen frequently.

@rmzelle
Copy link
Member

rmzelle commented Jan 28, 2013

Yes, that should work and be relatively maintenance free. In the meantime, I already updated the instructions for contributing files in https://github.com/citation-style-language/styles/blob/master/CONTRIBUTING.md , since this only has become a significant problem since we started directing users to use GitHub's new "New File" icon (https://github.com/blog/1327-creating-files-on-github).

@inukshuk inukshuk mentioned this pull request Apr 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants