New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ecole-doctorale-de-sciences-po-author-date-french.csl #3869
Create ecole-doctorale-de-sciences-po-author-date-french.csl #3869
Conversation
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
😟 There are some issues with your submission. Please check the test report for details. |
😃 Your submission passed all our automated tests. |
Thanks! Is the style guide for this citation format available online? We try to always include a "documentation" link in our repository styles. See https://github.com/citation-style-language/styles/wiki/Style-Requirements#10---documentation-link as well. Same holds for #3868. |
Dear Rintze,
The documentation is still not online, but will be available at this
address : https://sciencespo.libguides.com/zotero/styles
Did you now when the style will be included in the official repository ?
Best regards,
*Anna Couthures-Idrizi*
bibliothécaire
Direction des Ressources et de l'Information Scientifique
27 rue Saint-Guillaume 75337 Paris cedex 07 France
T. +33 (0)1 45 49 50 43
anna.couthuresidrizi@sciencespo.fr
Libguide Humanités <http:///>
www.sciencespo.fr
[image: Twitter Sciences Po] <https://twitter.com/sciencespo>
<https://www.facebook.com/sciencespo>
<https://www.linkedin.com/edu/school?id=12454>
<https://www.linkedin.com/edu/school?id=12454>
Le sam. 12 janv. 2019 à 05:50, Rintze M. Zelle <notifications@github.com> a
écrit :
… Thanks! Is the style guide for this citation format available online? We
try to always include a "documentation" link in our repository styles. See
https://github.com/citation-style-language/styles/wiki/Style-Requirements#10---documentation-link
as well.
Same holds for #3868
<#3868>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3869 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ao8bMTJyYDgk6dXsLK5CRgpNPruwTbZtks5vCWl-gaJpZM4Z5GTn>
.
|
(I'm happy to merge this before the styleguide goes live, but there are some quality issues with the style code, so please don't quite merge yet). Will review in detail tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A bunch of comments & suggested improvements in line. Please apply the same ideas to your other style submission.
<names variable="author"> | ||
<name form="short" and="text" delimiter-precedes-last="never" sort-separator=" " font-style="normal"> | ||
</name> | ||
</names> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's handle this with substitute
, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't understand how to do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you help me, please ?
<names variable="author"> | ||
<name form="long" and="text" name-as-sort-order="first" sort-separator=", " font-style="normal"> | ||
<name-part name="family" font-variant="small-caps"/> | ||
</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto here -- editor should just be in substitute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't understand how to do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you help me, please ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear all, for a lot of items, i just copied/pasted elements from other styles already in your repository. I do not understand why i should have to correct those elements.
If it's really necessary to correct them, could you please help me ?
Best regards,
Anna
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if you want a style hosted by us, which goes out to software with hundreds of thousands of end users, we absolutely insist on quality control on submission. If you want to have the style available, you can always self-host it.
We do this on a volunteer basis, so if you need significant help -- as in this case, where you essentially ask me to explain almost every change request -- this may take a bit longer, sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear Sebastian,
Thank you so much for your help !
I'm already volunteer for other academic subjects, and i'm well aware that people write you only when they have a problem or a claim ; so i deeply apologize if my last email hurted you, that was not the scope.
Now that you fixed all issues, what is the next step ? Can both styles (author date & note) be shared through styles repository ?
Best regards,
Anna
<macro name="access"> | ||
<choose> | ||
<if type="article article-journal article-magazine article-newspaper book broadcast chapter entry-dictionary entry-encyclopedia thesis graphic legal_case legislation manuscript map motion_picture paper-conference patent post post-weblog personal_communication report song speech webpage" match="any"> | ||
<text variable="URL" prefix="En ligne : " suffix=" "/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should all be wrapped into an if variable="URL"
test to avoid getting just the accessed date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't understand how to do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you help me, please ?
</else-if> | ||
<else-if type="chapter entry-dictionary entry-encyclopedia" match="any"> | ||
<group> | ||
<group suffix=" "> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this group and set a delimiter=" "
on the outer group for the spacing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't understand how to do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you help me, please ?
<macro name="collection"> | ||
<choose> | ||
<if is-numeric="collection-number"> | ||
<text variable="collection-title" prefix="(" suffix=""/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's put these two in a group with the parentheses around the group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't understand how to do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you help me, please ?
<if position="ibid-with-locator"> | ||
<group delimiter=", "> | ||
<text term="ibid" text-case="capitalize-first" font-style="italic" suffix="."/> | ||
<text variable="locator" prefix="p. "/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as above, use label
instead (also, presumably should be nbsp?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't understand how to do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you help me, please ?
<key variable="issued" sort="descending"/> | ||
</sort> | ||
<layout> | ||
<text macro="author" suffix=". "/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more elegant to handle all of these suffixes with a single delimiter=". "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't understand how to do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you help me, please ?
@AnnaCouthuresIdrizi, let us know if you need any help implementing @adam3smith's suggestions. We'd like to include these before accepting the style. And I see that https://sciencespo.libguides.com/zotero/styles is now online. Does the website describe the note and author-date citation formats itself anywhere? I briefly looked around but didn't see any examples of what citations should look like. |
This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks. |
Dear Rintze,
Thank your for your answer.
Yes, i think i need a little bit of help to apply the required
modifications.
I thought the CSL validator validation was enough...
Best regards,
*Anna Couthures-Idrizi*
bibliothécaire
Direction des Ressources et de l'Information Scientifique
27 rue Saint-Guillaume 75337 Paris cedex 07 France
T. +33 (0)1 45 49 50 43
anna.couthuresidrizi@sciencespo.fr
Libguide Humanités <http:///>
www.sciencespo.fr
[image: Twitter Sciences Po] <https://twitter.com/sciencespo>
<https://www.facebook.com/sciencespo>
<https://www.linkedin.com/edu/school?id=12454>
<https://www.linkedin.com/edu/school?id=12454>
Le sam. 19 janv. 2019 à 22:24, Rintze M. Zelle <notifications@github.com> a
écrit :
… @AnnaCouthuresIdrizi <https://github.com/AnnaCouthuresIdrizi>, let us
know if you need any help implementing @adam3smith
<https://github.com/adam3smith>'s suggestions. We'd like to include these
before accepting the style.
And I see that https://sciencespo.libguides.com/zotero/styles is now
online. Does the website describe the note and author-date citation formats
itself anywhere? I briefly looked around but didn't see any examples of
what citations should look like.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3869 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ao8bMb1FfcC4Hec33-hKarojTJFZwKsRks5vE40IgaJpZM4Z5GTn>
.
|
Could you specify where you need help/additional information? Just reply to my comments. |
😃 Your submission passed all our automated tests. |
😟 There are some issues with your submission. Please check the test report for details. |
😃 Your submission passed all our automated tests. |
😃 Your submission passed all our automated tests. |
Dear all,
I replied to all comments. For some of them, i need help to apply the
required corrections.
This style is really long-waited by our students.
Please, help...
Best regards,
*Anna Couthures-Idrizi*
bibliothécaire
Direction des Ressources et de l'Information Scientifique
27 rue Saint-Guillaume 75337 Paris cedex 07 France
T. +33 (0)1 45 49 50 43
anna.couthuresidrizi@sciencespo.fr
Libguide Humanités <http:///>
www.sciencespo.fr
[image: Twitter Sciences Po] <https://twitter.com/sciencespo>
<https://www.facebook.com/sciencespo>
<https://www.linkedin.com/edu/school?id=12454>
<https://www.linkedin.com/edu/school?id=12454>
Le mar. 26 févr. 2019 à 18:23, Sebastian Karcher <notifications@github.com>
a écrit :
… Could you specify where you need help/additional information? Just reply
to my comments.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3869 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ao8bMUh1cGsztFsFLlopW9U-9zathfj0ks5vRW10gaJpZM4Z5GTn>
.
|
😃 Your submission passed all our automated tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I was able to fix most things, but one question remaining
<if type="bill book chapter entry-dictionary entry-encyclopedia thesis legal_case manuscript map paper-conference song" match="any"> | ||
<choose> | ||
<if variable="publisher-place" match="any"> | ||
<text variable="publisher-place" suffix=" : "/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnnaCouthuresIdrizi -- I don't understand why this is marked as resolved? If I'm wrong about the above, you'd need to say why. I'm very skeptical that the code as is produces correct output.
😟 There are some issues with your submission. Please check the test report for details. |
😟 There are some issues with your submission. Please check the test report for details. |
…sl to sciences-po-ecole-doctorale-author-date.csl
😃 Your submission passed all our automated tests. |
(@adam3smith, the related #3868 automatically closed because of inactivity) |
😃 Your submission passed all our automated tests. |
Sorry for the wait. @AnnaCouthuresIdrizi if you want the note version added as well, you'd have to make the analogous changes implemented here on that style: #3868 . Let me know if you want me to reopen that issue |
Hello, |
dear all, |
See 3b here: |
No description provided.