New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create plant-genetic-resources-characterization-and-utilization.csl #4256
Create plant-genetic-resources-characterization-and-utilization.csl #4256
Conversation
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: plant-genetic-resources-characterization-and-utilization.csl (new)(Hancké et al., 2007; CSL search by example, 2012) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits -- mainly clean-up from the very specific content of the template.
</if> | ||
<else> | ||
<choose> | ||
<if variable="call-number"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that seems very odd -- I assume inherited? But would remove.
<if type="bill book graphic legal_case legislation motion_picture song" match="any"> | ||
<text variable="title" font-style="italic" text-case="title"/> | ||
</if> | ||
<else-if type="report" match="any"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed - remove.
</macro> | ||
<macro name="access-date"> | ||
<choose> | ||
<if type="webpage post post-weblog"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add match="any"
</else> | ||
</choose> | ||
</macro> | ||
<macro name="extra"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for? Better to remove -- I prefer not to have note/extra in styles.
</if> | ||
</choose> | ||
</macro> | ||
<macro name="un-sales"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems like a leftover - remove
<else-if type="bill book chapter graphic legal_case legislation motion_picture paper-conference song" match="any"> | ||
<choose> | ||
<if variable="collection-title"> | ||
<group delimiter=", "> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handle the spaces here more elegantly (e.g. no need for the one before "No." and the one before "Vol." should probably be a group prefix)
</choose> | ||
</macro> | ||
<macro name="citation-locator"> | ||
<group> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for this -- just delete macro
<text macro="author-short"/> | ||
<text macro="year-date"/> | ||
</group> | ||
<text macro="citation-locator"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and then handle the colon before the locator here.
<date variable="issued"> | ||
<date-part name="month" prefix=" "/> | ||
</date> | ||
<text variable="URL" prefix=". Available at " font-style="normal"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we pack this into a macro and handle available at with a term?
Thank you for the thorough review. Obviously not an ideal style to base this one on.
😟 There are some issues with your submission. 1 test failedplant-genetic-resources-characterization-and-utilization: must define all macros that are called by <text/> and <key/> elements
Please check the test report for details. |
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: plant-genetic-resources-characterization-and-utilization.csl (new)(Hancké et al., 2007; CSL search by example, 2012) |
Great thanks! |
via https://forums.zotero.org/discussion/78389/style-request-plant-genetic-resources-characterization-and-utilization