Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cryptogamie, bryologie #4350

Merged
merged 4 commits into from Dec 17, 2019

Conversation

Zoosystema
Copy link
Contributor

No description provided.

@csl-bot
Copy link

csl-bot commented Oct 10, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot
Copy link

csl-bot commented Oct 10, 2019

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain extra files (make sure styles have a ".csl" extension)

expected: []
     got: ["/home/travis/build/citation-style-language/styles/cryptogamie, bryologie"]

(compared using ==)

Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Oct 10, 2019

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain extra files (make sure styles have a ".csl" extension)

expected: []
     got: ["/home/travis/build/citation-style-language/styles/cryptogamie-bryologie"]

(compared using ==)

Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Oct 10, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

cryptogamie-bryologie.csl (new)
(Hancké et al. 2007; Anonymous 2012)
(Mares 2001; Fenner et al. 2019)

Fenner M., Crosas M., Grethe J.S., Kennedy D., Hermjakob H., Rocca-Serra P., Durand G., Berjon R., Karcher S., Martone M. & Clark T. 2019. — A data citation roadmap for scholarly data repositories. Scientific Data 6 (1): 28. https://doi.org/10.1038/s41597-019-0031-8
Mares I. 2001. — Firms and the welfare state: When, why, and how does social policy matter to employers?, in Hall P.A. & Soskice D. (eds.), Varieties of capitalism. The institutional foundations of comparative advantage. New York, Oxford University Press. p. 184–213.
Anonymous 2012. — CSL search by exampleAvailable from http://editor.citationstyles.org/searchByExample/ [accessed 15 December 2012]
Hancké, B., Rhodes, M. & Thatcher, M. (Eds.) 2007. — Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy, in . Oxford and New York, Oxford University Press.

@adam3smith
Copy link
Member

Thanks -- it looks like all of these styles are identical, is that right? If so, what's the publisher they're from? Is there a styleguide? And did you start with any style as a template?

@Zoosystema
Copy link
Contributor Author

Thanks for your help !
Indeed they are the Csl for all the journals of the Muséum national d'Histoire naturelle, in Paris.
All journals have the same format. I am a desk editor, and an author helped me to create this style but I do not know from which style he starts. I can ask him…

@adam3smith
Copy link
Member

Perfect. Would you be able to get us the following information:

  1. A link to the guide where this citation style is described
  2. If at all possible, the style the author started from (so yes, please do ask)
  3. An .xlsx (Excel) file with the following columns: Name of Journal, ISSN, eISSN that contains all your journals? We'll use that to automatically create style copies that are easier to maintain as the separate styles you've submitted.

Do let me know if you have any questions (and do feel free to write in French if that's at all easier for you)

@Zoosystema
Copy link
Contributor Author

Ok, I'll do this as soon as possible.

@Zoosystema
Copy link
Contributor Author

MNHN_journals.xlsx

Here is the table you asked me. I also added columns for the category field and for the links to the authors guideline which are different for each journal.

Finallly the author anwered that he didn't use any stylesheet, he created it directly.
Tell me if you need other informations.

@adam3smith
Copy link
Member

That's perfect, thank you! We'll take it from here.

@adam3smith adam3smith self-assigned this Oct 17, 2019
@Zoosystema
Copy link
Contributor Author

Great, Thank you for your help.

POBrien333 added a commit to POBrien333/journals that referenced this pull request Oct 29, 2019
@POBrien333
Copy link
Contributor

I've created the automatic styles based on that .xlsx.
Let me know if this is all good.

@Zoosystema
Copy link
Contributor Author

Thanks. I have two questions:
• is it normal that the journal Cryptogamie, Bryologie is missing in the table? Otherwise all if fine.
• why there is this link in the template?

@POBrien333
Copy link
Contributor

POBrien333 commented Oct 31, 2019

With this PR here it will add an independent style for Cryptogamie, Bryologie.
The other PR I made, will then automatically create the other styles for the missing MNHN journals, hence it is missing in that list.
citation-style-language/journals#83

@Zoosystema
Copy link
Contributor Author

So ok, thanks for the explanation

@Zoosystema
Copy link
Contributor Author

An why is there a link toward american chemical society in the template ?

@POBrien333
Copy link
Contributor

Check it here, I linked the wrong PR.
https://github.com/citation-style-language/journals/pull/83/files

No need to worry. It'll get reviewed and checked.

@Zoosystema
Copy link
Contributor Author

ok, it looks fine for me.
Thanks.

@stale
Copy link

stale bot commented Nov 30, 2019

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.

@stale stale bot added the waiting The ticket/pull request is awaiting input from the contributor/depositor label Nov 30, 2019
@Zoosystema
Copy link
Contributor Author

Dear POBrien333, before the discussion closes, can you give me news of the style? Is it deposited, should I do something? Thanks for your help.

@stale stale bot removed the waiting The ticket/pull request is awaiting input from the contributor/depositor label Dec 2, 2019
@POBrien333
Copy link
Contributor

@adam3smith and @rmzelle, the main curators of the repository, will be able to answer the question.
(and no, it's not deposited)

@csl-bot
Copy link

csl-bot commented Dec 17, 2019

😃 Your submission passed all our automated tests.

@rmzelle
Copy link
Member

rmzelle commented Dec 17, 2019

@Zoosystema, I (finally) added the styles to our repository. Apologies for the long wait.

@Zoosystema
Copy link
Contributor Author

Thank you @rmzelle !

@Zoosystema
Copy link
Contributor Author

Hi @POBrien333 and @rmzelle We are going to welcome in our publications a new journal which leaves the private publisher Elsevier to pass in Open access with us.
Name of Journal : Comptes rendus Palevol
ISSN: 1631-0683
We would therefore like to create the style sheet linked to the CSL Muséum national d'Histoire naturelle.
and delete the old style sheet linked to Elsevier <title>Comptes rendus - Palevol</title>
Please tell me how I should proceed.

POBrien333 added a commit to POBrien333/journals that referenced this pull request Jun 9, 2020
POBrien333 added a commit to POBrien333/journals that referenced this pull request Jun 9, 2020
@POBrien333
Copy link
Contributor

Thanks @Zoosystema

I have made the necessary Pull Requests to add it to the MNHN sjournals and remove it from Elsevier.
Over to Rintze.

adam3smith pushed a commit to citation-style-language/journals that referenced this pull request Sep 25, 2020
adam3smith pushed a commit to citation-style-language/journals that referenced this pull request Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants