Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ET&C dependent of CSE #4483

Merged
merged 5 commits into from Jan 8, 2020

Conversation

@csl-bot
Copy link

csl-bot commented Jan 2, 2020

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot
Copy link

csl-bot commented Jan 2, 2020

😟 There are some issues with your submission.

Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Jan 2, 2020

😟 There are some issues with your submission.

2 tests failed

international-journal-of-polymer-analysis-and-characterization: "template" link must point to an existing independent style

expected ["sociology-of-health-and-illness", "french3", "cell", "canadian-journal-of-earth-sciences", "jahrbuc...nvironmental-health-perspectives", "bulletin-of-the-american-schools-of-oriental-research", "oikos"] to include "environmental-toxicology-and-chemistry"

dependent/environmental-toxicology-and-chemistry: must have the same citation-format as its independent-parent

expected: :"author-date"
     got: :numeric

(compared using ==)

Diff:
@@ -1,2 +1,2 @@
-:"author-date"
+:numeric

Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Jan 2, 2020

😟 There are some issues with your submission.

1 test failed

international-journal-of-polymer-analysis-and-characterization: "template" link must point to an existing independent style

expected ["sociology-of-health-and-illness", "french3", "cell", "canadian-journal-of-earth-sciences", "jahrbuc...nvironmental-health-perspectives", "bulletin-of-the-american-schools-of-oriental-research", "oikos"] to include "environmental-toxicology-and-chemistry"

Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Jan 8, 2020

😃 Your submission passed all our automated tests.

@csl-bot
Copy link

csl-bot commented Jan 8, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

international-journal-of-polymer-analysis-and-characterization.csl (modified style; unchanged output for sample items)
[1,2]
[3,4]

[1]Hancké, B., Rhodes, M., Thatcher, M. 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York.
[2] 2012. CSL search by example. Citation Style Editor. [cited 15 December 2012]. Available from http://editor.citationstyles.org/searchByExample/.
[3]Mares, I. 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? In Varieties of capitalism. The institutional foundations of comparative advantage, eds Hall, P. A. and Soskice, D., pp 184–213. Oxford University Press, New York.
[4]Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., Clark, T. 2019. A data citation roadmap for scholarly data repositories. Sci. Data. 6:28.
dependent/environmental-toxicology-and-chemistry.csl (rendering failure)

@rmzelle rmzelle merged commit bb01625 into citation-style-language:master Jan 8, 2020
@rmzelle
Copy link
Member

rmzelle commented Jan 8, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants