Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create universitat-bremen-frankoromanistik-literaturwissenschaft.csl #7041

Merged
merged 4 commits into from May 9, 2024

Conversation

POBrien333
Copy link
Contributor

Via private client. The style has been thoroughly tested and reviewed. The person who commissioned the style asked to be listed as the author of the style so requests go to her if need be. I'm fine with that. @adam3smith I'd be grateful if you could review and merge this style when you are able to. Thanks a lot!

Via private client. The style has been thoroughly tested and reviewed.
The person who commissioned the style asked to be listed as the author of the style so requests go to her if need be. I'm fine with that.
@adam3smith I'd be grateful if you could review and merge this style when you are able to. Thanks a lot!
Copy link

github-actions bot commented May 8, 2024

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

github-actions bot commented May 8, 2024

😟 There are some issues with your submission.

2 tests failed

universitat-bremen-frankoromanistik-literaturwissenschaft: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[7, "7:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...RROR: Did not expect element locale there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

universitat-bremen-frankoromanistik-literaturwissenschaft: may not have any unused macros

expected: []
     got: ["author-container", "composer", "editor-collection", "recipient-show", "translator"]

(compared using ==)

Please check the test report for details.

Copy link

github-actions bot commented May 8, 2024

😟 There are some issues with your submission.

1 test failed

universitat-bremen-frankoromanistik-literaturwissenschaft: may not have any unused macros

expected: []
     got: ["author-container", "composer", "editor-collection", "recipient-show", "translator"]

(compared using ==)

Please check the test report for details.

@adam3smith
Copy link
Member

(please ping me again once you've fixed the redundant macros; I'll merge quickly as requested)

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label May 8, 2024
@bwiernik
Copy link
Member

bwiernik commented May 9, 2024

I can check again tomorrow too and merge if ready

Copy link

github-actions bot commented May 9, 2024

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

universitat-bremen-frankoromanistik-literaturwissenschaft.csl (new)
(“CSL search by example” 2012; Hancké et al. 2007)
(Fenner et al. 2019; Mares 2001)

anon.: CSL search by example. 2012. http://editor.citationstyles.org/searchByExample/. Accessed: 15.12.2012.
Fenner, Martin/Crosas, Mercè/Grethe, Jeffrey S. et al.: “A data citation roadmap for scholarly data repositories.” In: Scientific Data, Vol. 6, No. 1, 2019, p. 28.
Hancké, Bob/Rhodes, Martin/Thatcher, Mark (Eds.): Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press 2007.
Mares, Isabela: “Firms and the welfare state: When, why, and how does social policy matter to employers?” In: Hall, Peter A./Soskice, David (Eds.): Varieties of capitalism. The institutional foundations of comparative advantage. New York: Oxford University Press 2001, pp. 184–213.

@POBrien333
Copy link
Contributor Author

Ah, should've checked back last night! Was literally the last thing I did.
Macros removed now. Thank you :)

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label May 9, 2024
@adam3smith adam3smith merged commit a056170 into citation-style-language:master May 9, 2024
@adam3smith
Copy link
Member

Great, thanks!

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants