New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSL omitted in translation to "machine" form #19
Comments
Similar issues in several other tests, including Also textcase_NoSpaceBeforeApostrophe has invalid xml: </label prefix=" (" suffix=")" form="short"/> |
And here's the PR: |
I don't know, I'm doing something new (fooling around with writing a lua citeproc), so it's not that something that was working before broke. |
OK. I don't really know anything about this myself. Maybe @fbennett can offer insight. |
Not sure what is going on now!
and I notice that many of the .txt files are changed from their repository versions. (I wouldn't have expected this program to change the sources.) Reverting the commit you mention doesn't affect this. Am I doing something wrong? If I revert to 4a549a6, then the script succeeds but again I see changes in the .txt files. (Maybe just line endings.) The error noted above is still present with that version. |
OK, that error I understand, and can fix. Give me a bit. |
That error should be fixed. |
I just ran the script and looked at the "csl": "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<style xmlns=\"http://purl.org/net/xbiblio/csl\" I'm running Python 3.8.3. |
Again, on this I see what I expect: a full style; not the above. |
Reported in #19 (comment) (and I believe also by Norm)
Right; I clearly misread that one. So @jgm - some of this is now fixed. |
Great! That fixes all my xml parsing errors, thank you. I'm still wondering why the grind script changes the source files, but that's a more minor issue. |
Feel free to close this if you intend the changing .txt files. |
I'll leave it open for a bit in case @adam3smith or @fbennett have anything to say on that. But glad it's working now! Since you're looking at the test-suite now, if you have any time, I'd welcome input on #16. I've just pushed a PR that addresses it, I think. |
For |
@fbennett do you recommended we add that new test runner to this README? |
In
processor-tests/machines/name_BibliographyNameFormNeverShrinks.json
I seewhich leaves off the beginning of the CSL file. The whole thing is correctly represented in the corresponding (human) .txt file, and it seems to be valid. So this seems to be an issue with the generation of the machine-readable versions by
python processor.py --grind
.The text was updated successfully, but these errors were encountered: