Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add License Types & Providers #416

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheGamerzs
Copy link
Contributor

These are the only license providers that I have seen.
license2 may need to be verified to see how it's "activated". (i.e. switching SocialClub accounts or just having SocialClub multiple accounts present)

Copy link
Contributor

@PsychoShock PsychoShock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

I have left some comments if you wanna check them out. This is my personnal opinion for this PR.

Nice work! :)

Comment on lines +20 to +29
|Type ID|Provider|Type|Data Type|
|-|-|-|-|
|`steam`|Steam|[Steam ID](https://partner.steamgames.com/doc/webapi/isteamuserauth)|hex|
|`discord`|Discord|[User Id](https://discord.com/developers/docs/topics/oauth2#get-current-authorization-information-example-authorization-information)|int|
|`xbl`|Xbox Live||int|
|`live`|Microsoft PUID|Passport Unique Identifier|int|
|`license`|Rockstar Online Services|Hash|hex|
|`license2`|Rockstar Online Services|Hash|hex|
|`fivem`|CFX.re|User Id|int|
|`ip`|IP Adress|IPv4|string|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work correctly. It's because you did |Value| instead of | Value | so it won't parse correctly. :)

In Markdown, the standard format for a table header is with spaces surrounding the text to separate the pipes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants