server: fix leaking self-referential fx::Client objects

citizenfx · Jan 5, 2019 · 25e8494 · 25e8494
1 parent 37b5818
commit 25e8494
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/code/components/citizen-server-impl/src/ClientRegistry.cpp b/code/components/citizen-server-impl/src/ClientRegistry.cpp
@@ -28,7 +28,7 @@ namespace fx
 			m_clientsByNetId[weakClient.lock()->GetNetId()] = weakClient;
 		});
 
-		client->OnAssignPeer.Connect([=]()
+		client->OnAssignPeer.Connect([this, weakClient]()
 		{
 			m_clientsByPeer[weakClient.lock()->GetPeer()] = weakClient;
 
@@ -47,7 +47,7 @@ namespace fx
 
 				if (m_clientsBySlotId[slot].expired())
 				{
-					client->SetSlotId(slot);
+					weakClient.lock()->SetSlotId(slot);
 
 					m_clientsBySlotId[slot] = weakClient;