Camera shake after upgrading to DLC 2802

[damightylamb]

The server I am currently developing for have been reporting a "camera shake" while in 3rd person. I understand that there is a setting in FiveM that does disable this (see image) but reports from the players have been stating that the "fix" does not change the camera shake.

Was hoping for clarification on this setting on whether or not this setting was supposed to adjust that camera shake. If not, then what does this fix so I can clarify with the players of the server.

If this setting was supposed to fix that camera shake, then I suppose its a bug report then.

[FlawwsX]

Does not seem related to the DLC version.

It works fine on my end using 2802, but a user reported:

It only started when I reinstalled fivem. I had it disabled when i uninstalled, and then reinstalled. it was automatically checked, but it doesnt work.

[gottfriedleibniz]

With the 2802 RTTI changes, this offset is incorrect (28). DoAppState is never called and the DisableCameraShake hooks are never invoked.

Tangentially, with how DisableCameraShake is implemented, it is likely accidental that this works to begin with. (I think?)

Edit: While it's on my mind: CreateSimpleAllocatorHook also requires updated offsets for 2802.

[blattersturm]

it is likely accidental that this works to begin with

I think the main thing missing there would be configuring at runtime. PR author didn't have time to adjust that, but this indeed does need a mild rework.

(similarly, ouch! both those places linked look old and probably based on 2015-era assumptions and understanding about game code as well)

[thorium-cfx]

I think this got fixed with f435c5f, can this be confirmed so we can close this issue?

[damightylamb]

@thorium-cfx yes was fixed! Thank you!