Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add GetEntityFromStateBagName helper #1736

Merged
merged 1 commit into from Dec 7, 2022
Merged

feat: add GetEntityFromStateBagName helper #1736

merged 1 commit into from Dec 7, 2022

Conversation

AvarianKnight
Copy link
Contributor

Add a helper function as discussed on the forums.

@AvarianKnight AvarianKnight changed the title feat: add GetEntityFromStateBag helper feat: add GetEntityFromStateBagName helper Dec 5, 2022
blattersturm
blattersturm suggested changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@blattersturm blattersturm left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some stylistic remarks, in part for consistency with code elsewhere, in part because this'd handle invalid input a bit weirdly, and some doc suggestions.

(If need be I can check on this myself later, perhaps)

code/components/citizen-server-impl/src/state/ServerGameState_Scripting.cpp Outdated Show resolved Hide resolved
code/components/citizen-server-impl/src/state/ServerGameState_Scripting.cpp Outdated Show resolved Hide resolved
code/components/citizen-server-impl/src/state/ServerGameState_Scripting.cpp Outdated Show resolved Hide resolved
code/components/gta-net-five/src/CloneExperiments.cpp Outdated Show resolved Hide resolved
code/components/gta-net-five/src/CloneExperiments.cpp Outdated Show resolved Hide resolved
ext/native-decls/GetEntityFromStateBagName.md Show resolved Hide resolved
ext/native-decls/GetEntityFromStateBagName.md Outdated Show resolved Hide resolved
ext/native-decls/GetEntityFromStateBagName.md Outdated Show resolved Hide resolved
code/components/gta-net-five/src/CloneExperiments.cpp Outdated Show resolved Hide resolved
code/components/gta-net-five/src/CloneExperiments.cpp Outdated Show resolved Hide resolved
@AvarianKnight
Copy link
Contributor Author

AvarianKnight commented Dec 6, 2022 •
edited

It might also be worth having a GetPlayerFromStateBagName or something similar

@blattersturm
Copy link
Contributor

It might also be worth having a GetPlayerFromStateBagName or something similar

Perhaps, but that's out of scope here.

@blattersturm blattersturm merged commit a2b2ca9 into citizenfx:master Dec 7, 2022
@AvarianKnight AvarianKnight mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blattersturm blattersturm blattersturm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AvarianKnight @blattersturm