feat(extra-natives/five): read current & next gear from correct offsets #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue reported on forums, memory offsets used by CurrentGear and NextGear natives turned out to be incorrect / were reporting unexpected results: https://forum.cfx.re/t/native-getvehiclecurrentgear-is-reading-from-the-wrong-address-in-memory/5159163
The variables these offsets get assigned to were swapped by mistake, this was discovered by comparing offsets calculated at runtime with a known good Manual Transmission mod which reports expected numbers (linked in forum thread)
Tested the variable swap under all currently supported builds, the resulting offsets now line up nicely with the mod