fix(level-loader/five): no more city chunk if replacing map on b2699+ #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since b2699, some parts of the base map would load even if replacing the
level meta with a custom one. This is because patchday27 has a changeset
("CCS_PATCHDAY27_NG_STREAMING_MAP") which updates a few map chunks such
as dt1, but which lacks a <associatedMap>MO_JIM_L11</associatedMap> tag.
This was reported on https://forum.cfx.re/t/5162859, but likely also in
some other places prior given it's a fairly old bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since b2699, some parts of the base map would load even if replacing the level meta with a custom one. This is because patchday27 has a changeset ("CCS_PATCHDAY27_NG_STREAMING_MAP") which updates a few map chunks such as dt1, but which lacks a MO_JIM_L11 tag.
This was reported on https://forum.cfx.re/t/5162859, but likely also in some other places prior given it's a fairly old bug.