Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drive-by clipset fallback bypass native for FiveM #2380

Merged
merged 2 commits into from Feb 12, 2024

Conversation

Disquse
Copy link
Contributor

@Disquse Disquse commented Feb 7, 2024

Goal of this PR

Add a native that will allow bypassing the default game behavior preventing the use of overridden drive-by clipsets in certain scenarios to avoid clipping issues (for example, when there's more than 1 ped in a vehicle). So people can "manually" sync clipset drive-by overrides (SET_PED_DRIVE_BY_CLIPSET_OVERRIDE).

How is this PR achieving the goal

By implementing a native with desired behavior.

This PR applies to the following area(s)

FiveM

Successfully tested on

Game builds: 1604, 2060, 2189, 2372, 2545, 2612, 2699, 2802, 2944, 3095

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

Addressing a feature request left on the forum:
https://forum.cfx.re/t/setpeddrivebyclipsetoverride-sync-issue/5157275

Demonstration:

FiveM_hxIYUIyvgw.mp4

Disquse and others added 2 commits February 7, 2024 17:23
@Disquse Disquse force-pushed the fivem/drive-by-fallback-bypass branch from d4a0a59 to 00e7ded Compare February 8, 2024 16:59
@gottfriedleibniz gottfriedleibniz self-assigned this Feb 8, 2024
@gottfriedleibniz gottfriedleibniz added the ready-to-merge This PR is enqueued for merging label Feb 8, 2024
@thorium-cfx thorium-cfx merged commit 5a95b9f into citizenfx:master Feb 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants