-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IsVehicleStoppedAtTrafficLights #1115
Conversation
Thanks for your feedback, does this looks good to you ? |
Is this for red lights only? more testing required. | ||
This native checks if the given vehicle is stopped at a red light. | ||
|
||
**Note:** Will return false if the vehicle is stopped behind another vehicle waiting at a traffic light. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
false -> false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work since it's already in a ``` box no ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imported comments shouldn't be modified this way, instead it should be taken out of the fenced code block and written as a description of the native. That way everyone knows the documentation has been updated, it will show "Has modern docs" in the native reference site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes, check my comments. Thank you for your contribution!
Is this for red lights only? more testing required. | ||
This native checks if the given vehicle is stopped at a red light. | ||
|
||
**Note:** Will return false if the vehicle is stopped behind another vehicle waiting at a traffic light. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imported comments shouldn't be modified this way, instead it should be taken out of the fenced code block and written as a description of the native. That way everyone knows the documentation has been updated, it will show "Has modern docs" in the native reference site.
@@ -9,10 +9,10 @@ BOOL IS_VEHICLE_STOPPED_AT_TRAFFIC_LIGHTS(Vehicle vehicle); | |||
``` | |||
|
|||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove backticks, these are reserved for imported comments, not actual contributions by the community.
Is this for red lights only? more testing required. | ||
This native checks if the given vehicle is stopped at a red light. | ||
|
||
**Note:** Will return false if the vehicle is stopped behind another vehicle waiting at a traffic light. | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these as well.
Complement native documentation based on research.
Made some changes based on research, merging. Thanks! |
This behavior was checked using this code :