-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CreateMissionTrain.md #791
Conversation
Addition of different parameters for the native, more advanced documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there, some changes needed. I attached a file showing you how this PR should look. You can replace this PR with the contents from that file and resubmit if you want.
Thanks!
Commit modification
Hey, I've just sent the modification to a new commit |
I will approve this now, thank you! |
It'd probably be best to update the Also, should double check if removing |
I will take a look at an updated Update: It looks like |
Ok, I compared between a very old build of the game (1.0.323.1) by downloading from steam's depot downloader, and the current build, and it looks like these freight configurations were added, namely 24 and 25. I will be testing this and then most likely request changes, since there's more that could be added to this. |
24 and 25 are new train variations? |
The metro variation id got switched from 24 to 25 since build 2372. I did more research anyway and will explain what my proposed changes are soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I have went through the native, including train configurations, also comparing with older builds of the game and it turns out that there have been a couple changes since 2372.
Starting from the native, two new arguments were added which I documented:
NativeDB Added Parameter 6: BOOL isNetwork
NativeDB Added Parameter 7: BOOL netMissionEntity
I verified this by looking at the CREATE_VEHICLE
native that also calls matching methods for this.
Metro variation id has changed from 24 to 25 since build 2372.
I left my documentation attached. I also provided a basic Lua
example.
CreateMissionTrain.md
I update my PR to add your documentation? |
Correct, thank you! 🙂 |
ok it's good ;) |
Addition of different parameters for the native, more advanced documentation
The different types of variations were tested in game