Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CreateMissionTrain.md #791

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Conversation

Rytrak
Copy link
Contributor

@Rytrak Rytrak commented Jul 21, 2022

Addition of different parameters for the native, more advanced documentation
The different types of variations were tested in game

Addition of different parameters for the native, more advanced documentation
Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, some changes needed. I attached a file showing you how this PR should look. You can replace this PR with the contents from that file and resubmit if you want.

Thanks!

CreateMissionTrain.md

Commit modification
@Rytrak
Copy link
Contributor Author

Rytrak commented Jun 22, 2023

Hey, I've just sent the modification to a new commit

@4mmonium
Copy link
Contributor

Hey, I've just sent the modification to a new commit

I will approve this now, thank you!

@gottfriedleibniz
Copy link
Contributor

It'd probably be best to update the Train Models and variation id: section. If I recall correctly, b2372 added additional train configurations so the section as is will be only be true for >= b2372 or < b2372. My "trains.xml" comment was an incredibly lazy attempt at referencing that.

Also, should double check if removing freight is correct.

@4mmonium
Copy link
Contributor

4mmonium commented Jun 25, 2023

It'd probably be best to update the Train Models and variation id: section. If I recall correctly, b2372 added additional train configurations so the section as is will be only be true for >= b2372 or < b2372. My "trains.xml" comment was an incredibly lazy attempt at referencing that.

Also, should double check if removing freight is correct.

I will take a look at an updated trains.xml soon, thank you for your feedback! 🙂

Update: It looks like freight (the model name) certainly still exists in trains.xml in multiple instances.

@4mmonium
Copy link
Contributor

4mmonium commented Jun 25, 2023

Ok, I compared between a very old build of the game (1.0.323.1) by downloading from steam's depot downloader, and the current build, and it looks like these freight configurations were added, namely 24 and 25.

I will be testing this and then most likely request changes, since there's more that could be added to this.
Thank you for your feedback once again!

@Rytrak
Copy link
Contributor Author

Rytrak commented Jun 25, 2023

24 and 25 are new train variations?

@4mmonium
Copy link
Contributor

24 and 25 are new train variations?

The metro variation id got switched from 24 to 25 since build 2372. I did more research anyway and will explain what my proposed changes are soon.

Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have went through the native, including train configurations, also comparing with older builds of the game and it turns out that there have been a couple changes since 2372.

Starting from the native, two new arguments were added which I documented:

NativeDB Added Parameter 6: BOOL isNetwork
NativeDB Added Parameter 7: BOOL netMissionEntity

I verified this by looking at the CREATE_VEHICLE native that also calls matching methods for this.

Metro variation id has changed from 24 to 25 since build 2372.

I left my documentation attached. I also provided a basic Lua example.
CreateMissionTrain.md

@Rytrak
Copy link
Contributor Author

Rytrak commented Jun 27, 2023

I update my PR to add your documentation?

@4mmonium
Copy link
Contributor

I update my PR to add your documentation?

Correct, thank you! 🙂

@Rytrak
Copy link
Contributor Author

Rytrak commented Jun 27, 2023

ok it's good ;)

@titanium-cfx titanium-cfx merged commit 87807eb into citizenfx:master Jul 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants