Update ClearArea* of Cops, Peds and Projectiles. #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't arguments with their type changed need a cs_type to maintain compatibility with CS? |
Ah right, my bad. |
4mmonium
force-pushed
the
update/clear-area-of
branch
from
af95f7d
to
f318f53
Compare
MISC/ClearAreaOfCops.md
Outdated
| ``` | ||
| flags appears to always be 0 | ||
| Clears an area of cops at the given coordinates and radius. | ||
| `createNetEvent` specifies whether a `CClearAreaEvent` event of should be created for online use. |
There was a problem hiding this comment.
Is this line necessary considering its already defined in the parameters? (same goes for the other natives)
There was a problem hiding this comment.
I just corrected it, thanks!
4mmonium
force-pushed
the
update/clear-area-of
branch
from
f318f53
to
84f5a6c
Compare
This PR modifies an incorrectly named parameter in the aforementioned natives. The parameter was previously named `flags`, but this parameter actually defines whether a net event of `CClearAreaEvent` should be created or not upon native execution. I'm not entirely sure if changing parameter types is ok to do so (as in won't break anything, never done such thing), if so I can just set the type back to integer, let me know if so, thanks. Correct cs_type decls for ClearArea* natives Correct cs_type declarations for ClearArea* natives to preserve compatibility with C# scripts. Preserve function signature Preserve function signature for ClearAreaOfProjectiles. Last parameter was changed from int to BOOL. Remove redundant description about createNetEvent
4mmonium
force-pushed
the
update/clear-area-of
branch
from
84f5a6c
to
713b892
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies an incorrectly named parameter in the aforementioned natives.
The parameter was previously named
flags, but this parameter actually defines whether a net event ofCClearAreaEventshould be created or not upon native execution.I'm not entirely sure if changing parameter types is ok to do so (as in won't break anything, never done such thing), if so I can just set the type back to integer, let me know if so, thanks.