Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(natives/PED): Change documentation SET_PED_CONFIG_FLAGS #917

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BugCode1
Copy link

Adding a complete list of flags with string names

@AvarianKnight
Copy link
Contributor

Deleting the entire enum seems a bit weird, you should just update the current enums on the ones that changed.

Also please read the contributor guidelines, you shouldn't link to external websites as the links get deleted

@BugCode1
Copy link
Author

BugCode1 commented Sep 18, 2023

There are too many of them and they don't fit properly. To read them, you have to scroll horizontally and vertically or zoom out the browser.

On the other hand, many links of the pastebin website are in the documentation of some natives.

For example, this one:
https://docs.fivem.net/natives/?_0x8D8686B622B88120

However, if you say, I will put the whole list in the form of an array as before.

@AvarianKnight
Copy link
Contributor

There are too many of them and they don't fit properly. To read them, you have to scroll horizontally and vertically or zoom out the browser.

A lot of the ones in the list are already documented and are known true (any with CPED_CONFIG_FLAG_[name] are hash matches iirc, you'' notice some that have comments beside them because they likely don't match)

On the other hand, many links of the pastebin website are in the documentation of some natives.
For example, the: docs.fivem.net/natives/?_0x8D8686B622B88120

The doc you listed are from when FiveM did their original Natives import, any that link to outside websites should be replaced with in-line docs or link to the citizenfx/fivem-docs

@BugCode1
Copy link
Author

I updated all the values ​​in the same array as before.

@coalaura
Copy link
Contributor

Idk how accurate this source is but there seem to be a few more named ones here

Replaced with a better source
@BugCode1
Copy link
Author

Idk how accurate this source is but there seem to be a few more named ones here

The source you mentioned was better and had more flags that I added. Thanks

Comment on lines +475 to +476
_0x262A3B8E = 462,
_0x1AA79A25 = 463
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about that. I can't seem to found aything about that.

Copy link
Contributor

@PsychoShock PsychoShock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll PR the rest missing flag when this if get merged. I check them all and seem's the be all valid.

@coalaura
Copy link
Contributor

This PR seems to have the full list #1082

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants