This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
Added categories to posts #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cool, thanks for your contribution Denis! I'll take a look at it and probably merge it tomorrow morning :) |
|
Im, really glad and will be happy if can improve the blog gem. Sorry for the lack of tests and for any mistake but im just starting with spree. |
|
Thanks again for your help! I just merged your changes and added a couple of tests... take a peek and see if you can add some more ;) |
|
oh and did I get your name right on the readme? |
|
im very glad that you merged the pull request, thks and again sorry for the lack of tests im really getting started with this. For the name in readme you can use Denis Tierno. Thks again, and i hope help more! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I like very much of your extension and tried to implement some categories organization because i really need this im a current project. Im starting with rails and in fact this is my first pull request and i know that there a lot to improve, but i hope that you have some use for it.
Thks,
Denis