Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test-Context Error handling is not graceful #1122

Closed
bbortt opened this issue Feb 14, 2024 · 0 comments · Fixed by #1135
Closed

Test-Context Error handling is not graceful #1122

bbortt opened this issue Feb 14, 2024 · 0 comments · Fixed by #1135
Labels
good first issue A good point to start from for new contributrs Prio: High Type: Bug

Comments

@bbortt
Copy link
Collaborator

bbortt commented Feb 14, 2024 •
edited

Citrus Version

main@0c48227

Expected behavior

TestContext#handleError(String, String, String, Exception) returns the original exception, no matter what.

Link: https://github.com/citrusframework/citrus/blob/main/core/citrus-api/src/main/java/org/citrusframework/context/TestContext.java#L435.

Actual behavior

Whenever one of the listeners fails, this exception will be thrown instead of the original one. This testListeners... 3-tuple must be "graceful", catch any exceptions that would occur during invocation and handle it. Finally return the original cause.
@bbortt bbortt added Type: Bug Prio: High good first issue A good point to start from for new contributrs labels Feb 14, 2024
repananiromoney added a commit to repananiromoney/citrus that referenced this issue Feb 14, 2024
@repananiromoney
bug fix: Test-Context Error handling is not graceful citrusframework…
d39065d 
…#1122
repanareddysekhar pushed a commit to repanareddysekhar/citrus that referenced this issue Feb 14, 2024
@repananiromoney
Fix: Test-Context Error handling is not graceful citrusframework#1122
cbc638d
@bbortt bbortt mentioned this issue Feb 14, 2024
Closed
@bbortt bbortt linked a pull request Feb 14, 2024 that will close this issue
Fix: Test-Context Error handling is not graceful #1122 #1123
Closed
bbortt added a commit to postfinance/citrus that referenced this issue Mar 17, 2024
@bbortt
fix(citrusframework#1122): gracefully shutdown test context on error
76ec243
bbortt added a commit to postfinance/citrus that referenced this issue Mar 17, 2024
@bbortt
fix(citrusframework#1122): gracefully shutdown test context on error
fdbc60f
@bbortt bbortt mentioned this issue Mar 17, 2024
Merged
bbortt added a commit to postfinance/citrus that referenced this issue Mar 21, 2024
@bbortt
fix(citrusframework#1122): gracefully shutdown test context on error
992fdd5
bbortt added a commit that referenced this issue Mar 21, 2024
@bbortt
fix(#1122): gracefully shutdown test context on error
8e45846
christophd pushed a commit that referenced this issue Apr 23, 2024
@bbortt @christophd
fix(#1122): gracefully shutdown test context on error
3513766 
(cherry picked from commit 8e45846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good point to start from for new contributrs Prio: High Type: Bug
Projects
None yet
Milestone
No milestone
1 participant
@bbortt