Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#948): Log proper test step index on incremental Citrus tests #1151

Merged
merged 1 commit into from Apr 24, 2024
Merged

fix(#948): Log proper test step index on incremental Citrus tests #1151

merged 1 commit into from Apr 24, 2024

Conversation

turing85
Copy link
Contributor

Avoid all test steps to be reported as "TEST STEP 0" for incremental tests

(cherry picked from commit 21aeb43)

@christophd @turing85
fix(citrusframework#948): Log proper test step index on incremental C…
6ef05f1 
…itrus tests

Avoid all test steps to be reported as "TEST STEP 0" for incremental tests

(cherry picked from commit 21aeb43)
@turing85
Copy link
Contributor Author

@christophd It would be nice if we could produce a 3.x release with this fix.

@bbortt
Copy link
Collaborator

bbortt commented Apr 19, 2024

it's hard to imagine what's happening currently and what should happen, with just this change being present. please add a test that proves the desired behavior.

@turing85
Copy link
Contributor Author

it's hard to imagine what's happening currently and what should happen, with just this change being present. please add a test that proves the desired behavior.

This is just a cherry-pick from a commit that is already on main...

@bbortt
Copy link
Collaborator

bbortt commented Apr 19, 2024

hmm, I see. sorry, didn't read the description to the end.

@bbortt bbortt changed the base branch from 3.x to support/3.0.0 April 19, 2024 09:11
@bbortt bbortt self-requested a review April 19, 2024 09:11
@bbortt
Copy link
Collaborator

bbortt commented Apr 19, 2024

would you mind cherry-pick'ing it upon the updated base?

we're planning to release the backport of #1148 soon. we could easily include this PR as well.

@turing85
Copy link
Contributor Author

turing85 commented Apr 24, 2024 •
edited

would you mind cherry-pick'ing it upon the updated base?

we're planning to release the backport of #1148 soon. we could easily include this PR as well.

@bbortt here you are.

@turing85 turing85 closed this Apr 24, 2024
@turing85 turing85 mentioned this pull request Apr 24, 2024
Closed
@turing85 turing85 reopened this Apr 24, 2024
@turing85 turing85 changed the base branch from support/3.0.0 to 3.x April 24, 2024 09:30
@turing85
Copy link
Contributor Author

Reopened and set base back to 3.x. See #1152 (comment)

@christophd christophd merged commit d84f6ff into citrusframework:3.x Apr 24, 2024
@bbortt
Copy link
Collaborator

bbortt commented Apr 25, 2024

I am so sorry @turing85 .. I didn't know what branch @christophd uses and had already done #1148 into support/3.0.0. totally my bad! thanks for the contribution ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbortt bbortt Awaiting requested review from bbortt

Assignees

@turing85 turing85

Labels
Prio: High State: WIP Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@turing85 @bbortt @christophd