Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album artwork thumbnail is sometimes wrong #10

Closed
hawkeye0203 opened this issue Dec 20, 2013 · 11 comments
Closed

Album artwork thumbnail is sometimes wrong #10

hawkeye0203 opened this issue Dec 20, 2013 · 11 comments
Labels

Comments

@hawkeye0203
Copy link

It seems random when it happens, but the album artwork that shows on the notification bubble will sometimes be of the last song or another song from the past.

@citruspi
Copy link
Owner

@hawkeye0203,

That's unfortunate to hear. I haven't noticed this happening, but I will keep an eye out and will review the code.

If you happen to figure out the problem, please feel free to submit a pull request.

Have a great holiday.

@citruspi

@citruspi
Copy link
Owner

Hey @hawkeye0203,

I just realized what may have caused the error and implemented a fix which worked for me.

Could you build the project and let me know if you continue to have issues with incorrect album art? (If you don't know how to build it, or are unable to, let me know and I'll send you a compiled copy).

@citruspi

citruspi added a commit that referenced this issue Dec 31, 2013
Instead, set it to nil on play state change if the track has changed. This should make album art available to notifications delivered on shortcut presses.
@citruspi
Copy link
Owner

@hawkeye0203,

That last commit, 4b47903, should fix the lack of album art in notifications produced by pressing the shortcut.

@citruspi

@hawkeye0203
Copy link
Author

@citruspi Wow that was fast. Unfortunately I don't know how to build this.

@citruspi
Copy link
Owner

@hawkeye0203,

Here, try this.

@citruspi

@hawkeye0203
Copy link
Author

@citruspi thank you! I have it running as I type. I'll post back if I see anything. Great work man! This little app is exactly what I wanted out of the Spotify app.

@citruspi
Copy link
Owner

@hawkeye0203,

No problem!

Honestly, it's thanks to contributors and people who submit bugs that the app is what it is, so thank you! 😀

I hope it fixes the issue, but if you have any problems, do let me know.

Happy holidays.

@citruspi

@bwiggs
Copy link

bwiggs commented Feb 8, 2015

I just came here to report this bug. It's happened 3x in a row for me when the song changes, like it's stuck. Running v0.4.8 from homebrew cask. Spotify v0.9.15.27.g87efe634

screenshot 2015-02-08 14 35 06

Here's the expected Artwork:
screenshot 2015-02-08 14 37 58

@citruspi
Copy link
Owner

citruspi commented Feb 8, 2015

@bawigga,

This issue was resolved in version 0.5.0 which was released on October 27, 2014.

Unfortunately, I haven't released a signed binary since 0.4.8 which is why the website and Homebrew Cask both present 0.4.8.

If you'd like to update you could use the link I provided above to @hawkeye0203. However, the link is for a beta release of 0.5.0 which just fixed that issue.

If you'd like a more recent version, I'd recommend building the 0.5.X branch which contains version 0.5.1.

Sorry for any inconvenience.

@citruspi

@citruspi
Copy link
Owner

@bawigga @hawkeye0203 ,

I just wanted to give you an update. Yesterday I signed and published binaries for versions 0.5.0 and 0.5.1, feel free to download the latest version.

@citruspi

@bwiggs
Copy link

bwiggs commented Feb 24, 2015

@citruspi Thanks! Just installed from brew cask!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants