Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated icons based on Spotify's redesign #48

Closed
randallbruder opened this issue Jul 28, 2015 · 19 comments
Closed

Updated icons based on Spotify's redesign #48

randallbruder opened this issue Jul 28, 2015 · 19 comments

Comments

@randallbruder
Copy link
Contributor

Here's updated assets for Spotify-Notifications, based on the Spotify redesign. Included are:

AppIcon.icns
icon.icns
status_bar_colour.tiff

https://dl.dropboxusercontent.com/u/8895/spotify-notifications-icons.zip

Here's what it looks like with the proper icons:
image

@swrobel
Copy link

swrobel commented Jul 29, 2015

👍

@drewcovi
Copy link

drewcovi commented Oct 1, 2015

@randybruder could you PR that thing? or create a fork?

@randallbruder
Copy link
Contributor Author

@drewcovi I don't see how, the three files mentioned in the original post aren't in the Github project, just the compiled release. Don't know how to PR/fork it if the files aren't there for me to replace.

@robinnorth
Copy link
Contributor

@randybruder Check the 0.5.X branch (https://github.com/citruspi/Spotify-Notifications/tree/0.5.X), the status bar assets are under Spotify Notifications and the app icons are under Spotify Notications/Images.xcassets/AppIcon.appiconset.

@evansimoni
Copy link

+1 for this PR

@randallbruder
Copy link
Contributor Author

Ok, made a PR. No idea if I did it right.

#54

@drewcovi
Copy link

drewcovi commented Oct 6, 2015

@randybruder I think you did it right, but the images are the old green not the new green.

@randallbruder
Copy link
Contributor Author

Ok, think I did it right this time.

#55

@drewcovi
Copy link

drewcovi commented Oct 6, 2015

dy-no-mite! well done on what I'm guessing is a first PR! For future reference, you can always continue to commit to an open PR, no need to close and create anew!

@randallbruder
Copy link
Contributor Author

Well, first two now. It was the different branches thing that was tripping me up, I didn't realize forking a repo would also fork all the branches too. Thanks for your help.

@evansimoni
Copy link

Rad! Does anyone know how to update the application file on the main website?

@randallbruder
Copy link
Contributor Author

That would involve compiling the code (probably updating the version to 0.5.2) and having @citruspi update the main website.

@citruspi
Copy link
Owner

citruspi commented Oct 7, 2015

That would involve compiling the code (probably updating the version to 0.5.2) and having @citruspi update the main website.

Correct. Sorry about dropping the ball on this, it's been on my todo list but it just kept getting postponed.

I'll need to do a couple things to get the pull request shipped. I'd like to accomplish these today, but I'm going to provide a checklist so that the status of the issue is a little more transparent.

I'll update this issue as I make progress towards it.

Also, big thanks to @randybruder for the pull request and congrats on the first (two) pull request(s)! 🎉

@citruspi
Copy link
Owner

citruspi commented Oct 8, 2015

Okay, so its been merged, archived, signed, tagged, and released. The website has been updated.

I've submitted a pull request to Homebrew Cask for the new version - Homebrew/homebrew-cask#14276.

I think once that's merged in we're good to go.

@randallbruder
Copy link
Contributor Author

Hot damn

@drewcovi
Copy link

drewcovi commented Oct 8, 2015

👍

@citruspi
Copy link
Owner

citruspi commented Oct 8, 2015

Well, it's official. 🍰

@robinnorth
Copy link
Contributor

Nice one! 🎉

@evansimoni
Copy link

This is great, thanks @citruspi @randybruder !
👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants