Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version not working - notifications aren't shown #8

Closed
gostaj opened this issue Nov 27, 2013 · 8 comments
Closed

New version not working - notifications aren't shown #8

gostaj opened this issue Nov 27, 2013 · 8 comments
Labels
bug

Comments

@gostaj
Copy link

gostaj commented Nov 27, 2013

Hi, thanks for a great app.
I was a happy user until I upgraded to the latest version.
Now I don't see any notifications anymore. I haven't changed any settings, haven't upgraded my OS X or anything.
The app is running, I see the menu bar icon and can change the preferences but no notifications are shown.

I think this is related to the pull request by @jamessnee

Spotify-Notifications version: 0.4.5
OS X version: 10.8.5
Spotify-Notifications is enabled (just like before) under system preferences->notifications.

Error from the Console app:

11/27/13 1:42:18.960 PM Spotify Notifications[10207]: -[_NSConcreteUserNotification setContentImage:]: unrecognized selector sent to instance 0x7fdbe9a2f580
11/27/13 1:42:18.961 PM Spotify Notifications[10207]: -[_NSConcreteUserNotification setContentImage:]: unrecognized selector sent to instance 0x7fdbe9a2f580
11/27/13 1:42:18.962 PM Spotify Notifications[10207]: (
0 CoreFoundation 0x00007fff93e24b06 __exceptionPreprocess + 198
1 libobjc.A.dylib 0x00007fff9593f3f0 objc_exception_throw + 43
2 CoreFoundation 0x00007fff93ebb40a -[NSObject(NSObject) doesNotRecognizeSelector:] + 186
3 CoreFoundation 0x00007fff93e1302e forwarding + 414
4 CoreFoundation 0x00007fff93e12e18 _CF_forwarding_prep_0 + 232
5 Spotify Notifications 0x000000010440d1cc Spotify Notifications + 29132
6 CoreFoundation 0x00007fff93e8102c ____CFXNotificationPostToken_block_invoke_0 + 284
7 CoreFoundation 0x00007fff93de1cd2 CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK + 18
8 CoreFoundation 0x00007fff93da247f CFRunLoopDoBlocks + 255
9 CoreFoundation 0x00007fff93dc6c7c __CFRunLoopRun + 1948
10 CoreFoundation 0x00007fff93dc60e2 CFRunLoopRunSpecific + 290
11 HIToolbox 0x00007fff90157eb4 RunCurrentEventLoopInMode + 209
12 HIToolbox 0x00007fff90157c52 ReceiveNextEventCommon + 356
13 HIToolbox 0x00007fff90157ae3 BlockUntilNextEventMatchingListInMode + 62
14 AppKit 0x00007fff8f454533 _DPSNextEvent + 685
15 AppKit 0x00007fff8f453df2 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 128
16 AppKit 0x00007fff8f44b1a3 -[NSApplication run] + 517
17 AppKit 0x00007fff8f3efbd6 NSApplicationMain + 869
18 libdyld.dylib 0x00007fff973ef7e1 start + 0
19 ??? 0x0000000000000002 0x0 + 2
)
11/27/13 1:42:20.735 PM Spotify Notifications[10207]: -[_NSConcreteUserNotification setContentImage:]: unrecognized selector sent to instance 0x7fdbe9b187c0
11/27/13 1:42:20.737 PM Spotify Notifications[10207]: An uncaught exception was raised
11/27/13 1:42:20.738 PM Spotify Notifications[10207]: -[_NSConcreteUserNotification setContentImage:]: unrecognized selector sent to instance 0x7fdbe9b187c0
11/27/13 1:42:20.739 PM Spotify Notifications[10207]: (
0 CoreFoundation 0x00007fff93e24b06 __exceptionPreprocess + 198
1 libobjc.A.dylib 0x00007fff9593f3f0 objc_exception_throw + 43
2 CoreFoundation 0x00007fff93ebb40a -[NSObject(NSObject) doesNotRecognizeSelector:] + 186
3 CoreFoundation 0x00007fff93e1302e __forwarding + 414
4 CoreFoundation 0x00007fff93e12e18 CF_forwarding_prep_0 + 232
5 Spotify Notifications 0x000000010440cb34 Spotify Notifications + 27444
6 Spotify Notifications 0x0000000104408a39 Spotify Notifications + 10809
7 CoreFoundation 0x00007fff93e108a9 NSDictionaryEnumerate + 1081
8 Spotify Notifications 0x0000000104408986 Spotify Notifications + 10630
9 HIToolbox 0x00007fff90130d1a _ZL23DispatchEventToHandlersP14EventTargetRecP14OpaqueEventRefP14HandlerCallRec + 1206
10 HIToolbox 0x00007fff901301e9 _ZL30SendEventToEventTargetInternalP14OpaqueEventRefP20OpaqueEventTargetRefP14HandlerCallRec + 410
11 HIToolbox 0x00007fff90145fc9 SendEventToEventTarget + 40
12 AppKit 0x00007fff8f53599d -[NSApplication sendEvent:] + 6618
13 AppKit 0x00007fff8f44b21a -[NSApplication run] + 636
14 AppKit 0x00007fff8f3efbd6 NSApplicationMain + 869
15 libdyld.dylib 0x00007fff973ef7e1 start + 0
16 ??? 0x0000000000000002 0x0 + 2
)
11/27/13 1:42:23.397 PM Spotify Notifications[10207]: -[_NSConcreteUserNotification setContentImage:]: unrecognized selector sent to instance 0x7fdbe9a2a7e0
11/27/13 1:42:23.398 PM Spotify Notifications[10207]: -[_NSConcreteUserNotification setContentImage:]: unrecognized selector sent to instance 0x7fdbe9a2a7e0
11/27/13 1:42:23.399 PM Spotify Notifications[10207]: (
0 CoreFoundation 0x00007fff93e24b06 __exceptionPreprocess + 198
1 libobjc.A.dylib 0x00007fff9593f3f0 objc_exception_throw + 43
2 CoreFoundation 0x00007fff93ebb40a -[NSObject(NSObject) doesNotRecognizeSelector:] + 186
3 CoreFoundation 0x00007fff93e1302e ___forwarding + 414
4 CoreFoundation 0x00007fff93e12e18 _CF_forwarding_prep_0 + 232
5 Spotify Notifications 0x000000010440d1cc Spotify Notifications + 29132
6 CoreFoundation 0x00007fff93e8102c ____CFXNotificationPostToken_block_invoke_0 + 284
7 CoreFoundation 0x00007fff93de1cd2 CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK + 18
8 CoreFoundation 0x00007fff93da247f __CFRunLoopDoBlocks + 255
9 CoreFoundation 0x00007fff93dc6c7c __CFRunLoopRun + 1948
10 CoreFoundation 0x00007fff93dc60e2 CFRunLoopRunSpecific + 290
11 HIToolbox 0x00007fff90157eb4 RunCurrentEventLoopInMode + 209
12 HIToolbox 0x00007fff90157c52 ReceiveNextEventCommon + 356
13 HIToolbox 0x00007fff90157ae3 BlockUntilNextEventMatchingListInMode + 62
14 AppKit 0x00007fff8f454533 _DPSNextEvent + 685
15 AppKit 0x00007fff8f453df2 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 128
16 AppKit 0x00007fff8f44b1a3 -[NSApplication run] + 517
17 AppKit 0x00007fff8f3efbd6 NSApplicationMain + 869
18 libdyld.dylib 0x00007fff973ef7e1 start + 0
19 ??? 0x0000000000000002 0x0 + 2
)
@jamessnee
Copy link
Contributor

Yes this is because 10.8 doesn't have the API hook for setting the content image of a notification. Maybe I should use the pre-processor to strip this stuff out if the version of OS X is below 10.9.

@citruspi
Copy link
Owner

@gostaj,

Unfortunately, I believe that @jamessnee is correct.

The two solutions that I can think of would be to

  • stop supporting anything less than OS X 10.9
  • only provide the image on OS X 10.9, and an image-free notification on an OS X version under that

I'll probably publish a fix for it (most likely the second option) sometime today or tomorrow.

Sorry about it breaking. :/

— @citruspi

@gostaj
Copy link
Author

gostaj commented Nov 27, 2013

Thanks for the quick reply and service.

Yes, I would suggest the second option since a lot of people haven't upgraded to 10.9 for various reasons.

@citruspi
Copy link
Owner

@gostaj,

Could you tell me if this build fixes your issue?

Thanks.

— @citruspi

@gostaj
Copy link
Author

gostaj commented Nov 27, 2013

It works partially. The bug is still present for the "Show current song" functionality but the notification is shown when a song starts playing.

@citruspi
Copy link
Owner

@gostaj

I've uploaded a new build. Could you verify that this build fixes the bug with the "Show Current Song" functionality as well?

— @citruspi

@gostaj
Copy link
Author

gostaj commented Nov 27, 2013

Yes, now it works. Sweet work Mihir!

@citruspi
Copy link
Owner

@gostaj,

Awesome, glad to hear that it works!

I've uploaded a new developer-signed bundle here which contains the fix.

Thanks for opening an issue and alerting me to the problem.

— @citruspi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gostaj @jamessnee @citruspi