Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification does not show using keyboard shortcut when app first starts #19

Closed
chrowe opened this issue Mar 21, 2014 · 6 comments
Closed

Comments

@chrowe
Copy link

chrowe commented Mar 21, 2014

Environment

  • OS X 10.9.2
  • Spotify 0.9.7.16.....
  • Spotify Notifications 0.4.8

To reproduce:

  • Open Spotify and play a song
  • Open Spotify Notifications
  • If you don't have a "Show Current Song" keyboard shortcut set then set one, else
  • Press you keyboard shortcut (F5 in my case)

What I get:

  • Sound plays
  • "Spotify Notifications" entry shows up in notifications center sidebar.
    menubar-2
  • No popup shows

If I open Spotify Notifications first or skip to the next song after opening Spotify Notifications then everything seems to work fine.

@citruspi
Copy link
Owner

@chrowe,

This happens because Spotify Notifications gets song information from notifications sent by Spotify when the play state changes (i.e when a track begins playing or is paused).

So, if Spotify begins playing a song before Spotify Notifications is started, Spotify Notifications misses the notification from Spotify and produces a notification with no content - which is why it doesn't popup.

As you noted, if you play/pause/skip after opening Spotify Notifications, everything works. Depending on how much you use Spotify (and Spotify Notifications), I'd recommend just having it start on login.

In addition, I'll implement a check so that empty notifications are not produced.

@citruspi

@kianlavi
Copy link

kianlavi commented May 2, 2014

@citruspi That makes total sense. Thanks so much for clearing that up, cause I was definitely confused at first. I've been using SizzlingKeys for years and it produces a 'No Song Playing' toast if iTunes is closed or it just has no information.

@citruspi
Copy link
Owner

citruspi commented May 2, 2014

@kianlavi,

Would you rather see a "No Song Playing" notification or no notification at all?

@citruspi

@kianlavi
Copy link

kianlavi commented May 5, 2014

I personally rely on the keyboard shortcut to see what song is playing at
any given moment, so I think usability would be enhanced by a toast even
when nothing's playing. Something along the lines of what you said or
simply, 'No song is playing'.

On Thursday, May 1, 2014, Mihir Singh notifications@github.com wrote:

@kianlavi https://github.com/kianlavi,

Would you rather see a "No Song Playing" notification or no notification
at all?

@citruspi https://github.com/citruspi


Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-41984037
.

Cheers,
Kian H. Lavi

@citruspi
Copy link
Owner

@kianlavi, @chrowe,

I've added a few lines of code which will produce a notification when the shortcut is activated even if there is no song information recorded.

It will be included in the next release (which will be before June 02), but if you want it before then, feel free to clone and build the project yourself. If you do build it yourself, please let me know if you have any issues.

Thanks.

@citruspi

@kianlavi
Copy link

Thanks again, you're awesome Mihir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants