New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Last.FM integration #20
Conversation
Build in functionality
…tifications' option. -- The "new tracks" pref wasn't actually looking at all tracks ever played and was confusing UX There was no way to disable notifications, without closing the app altogether
You know what, I think we can make the "Play/Pause => Show notification" preference clearer. I made a general change, but I just realised, I kind of got rid of the play-pause feature. Let me have another go at that... brb |
Hey @hadimichael, This is some great stuff, but I'd appreciate it if you could split the different changes (i.e. Last.fm integration, UX changes, typo fixes, fair credit, etc.) into separate pull requests. |
Fair call. Edit: Hey @citruspi because the changes I made are not entirely sequential and were all done on master (oops), it's going to be tricky to break it all up. I tried branching it, but it got very messy. I'm open to suggestions, but it looks like it's going to have to come through in one request. Sorry mate. |
Hmm, I'll take a look at the commits tomorrow and figure out a good way to handle it. I'll reopen this pull request for now. Either way, thanks for contributing. |
Cool. Thanks. I also went back and fixed up that Preferences change I made. Check out the newest commits here. https://github.com/hadimichael/Spotify-Notifications/commits/master I can include those in a separate pull-request, immediately after this one goes through. |
Any changes here? |
Not yet, but I do plan to merge the changes. I've just been busy, last week with projects, and this week with PyCon. Before merging, I just want to actually go through and read the changes to the code. However, I do have one change I'd like made before I'll merge.
I don't particularly care that you removed my name from it, as I planned to do that anyway, but I disagree that linking to the Contributor Graph is the best way to give fair credit. In the past, I've seen that it takes some time for someone to appear on the Graph, and sometimes they never do. I think that instead you should link to the Thoughts? |
I've made a few changes here: