-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Estimote nearable support #35
Add Estimote nearable support #35
Conversation
Allow the manufacturer specific portion of the BLE advert data to be parsed for Nearables information. Including identifier, hardware and firmware version, temperature and movement state.
Account for the scanner passing a subset of the advert data for parsing
Update scanner to allow Estimote Nearables to be returned in results. With basic device filtering using the identifier support in the existing estimote device filter
@@ -168,6 +168,7 @@ def process_packet(self, pkt): | |||
if not ( \ | |||
((self.mode & ScannerMode.MODE_IBEACON) and (pkt[19:23] == b"\x4c\x00\x02\x15")) or \ | |||
((self.mode & ScannerMode.MODE_EDDYSTONE) and (pkt[19:21] == b"\xaa\xfe")) or \ | |||
((self.mode & ScannerMode.MODE_ESTIMOTE) and (pkt[23:25] == b"\x5d\x01")) or \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure if reusing the same device filter and scan mode setting would be acceptable or not.
What's the coverage threshold for the project? |
2359153
to
f88a7c0
Compare
f88a7c0
to
02bf2a0
Compare
Thank you for your contribution! |
Check the frame type for manufacturer specific data when iterating over the advertising data elements.
I've updated the PR to iterate over the advert data elements and check for a manufacturer specific type, moving the LTV struct into the parser. I also believe this could stand to be more generic. |
Great, thanks! I merged your changes into a release branch where I will integrate this PR and #36. |
I merged #35 and #36 and refactored all beacon definitions to use the generic ltv parser. The tests look fine, but since I don't have the hardware at hand, I cannot test the actual scanner. |
Apologies for the delay in replying. I've tested the release1.4.0 branch and everything is working. |
Add packet parsing and scanning support for Estimote 'Sticker Beacons' advertising 'Nearable' frames.