Skip to content

Commit

Permalink
Update CONTRIBUTING-development.md
Browse files Browse the repository at this point in the history
Co-authored-by: Jelte Fennema-Nio <jelte.fennema@microsoft.com>
  • Loading branch information
onurctirtir and JelteF committed Jan 31, 2024
1 parent 722eea9 commit 9f2bfc3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CONTRIBUTING-development.md
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,6 @@ But when you're asking for a review, you're asking for someone to review your wo
* Tests should **define functions** for repetitive actions, e.g., by wrapping usual queries used to check catalog tables.
If the function is presumed to be used by other tests in future, then the function needs to defined in `multi_test_helpers.sql`.
* If you're adding a new file, consider using `src/test/regress/bin/create_test.py` to create the file. Or if you want to manually create it, make sure that your test file creates a schema and that it drops the schema at the end of the test to make sure that it doesn't leak any objects behind. See which lines `src/test/regress/bin/create_test.py` adds to the test file to understand what you need to do.
* If you're adding a new file, consider using `src/test/regress/bin/create_test.py your_new_test_name` to create the file. Or if you want to manually create it, make sure that your test file creates a schema and that it drops the schema at the end of the test to make sure that it doesn't leak any objects behind. See which lines `src/test/regress/bin/create_test.py` adds to the test file to understand what you need to do.
For the object that are not bound to a schema, make sure to drop them at the end of the test too, such as databases and roles.

0 comments on commit 9f2bfc3

Please sign in to comment.