Append IF NOT EXISTS to deparsed CREATE SERVER commands #3875
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3875 +/- ##
=======================================
Coverage 91.57% 91.57%
=======================================
Files 185 185
Lines 36553 36554 +1
=======================================
+ Hits 33473 33475 +2
+ Misses 3080 3079 -1 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3875 +/- ##
=======================================
Coverage 91.57% 91.57%
=======================================
Files 185 185
Lines 36553 36554 +1
=======================================
+ Hits 33473 33475 +2
+ Misses 3080 3079 -1 |
|
I cannot foresee any problems with that (also we seem to considered this earlier as well). I guess on local citus tables, we're going to have both the shell table and the shard point to the same server. Is this the reason for this change? If that's the case, I need think a bit more on that (though we can merge this anyway) |
|
I actually thought in that way:
We should think a bit more on this in #3852. But I guess even if we decide to create another server object for the shard there, changes done in this pr shouldn't do any harm I think. |
Append IF NOT EXISTS to CREATE SERVER commands generated by pg_get_serverdef_string function when deparsing an existing server object that a foreign table depends.
onurctirtir
force-pushed
the
create-server-append-if-not-exists
branch
from
98a52d8
to
5634cbb
Compare
Codecov Report
@@ Coverage Diff @@
## master #3875 +/- ##
==========================================
- Coverage 91.57% 91.57% -0.01%
==========================================
Files 185 185
Lines 36555 36554 -1
==========================================
- Hits 33477 33475 -2
- Misses 3078 3079 +1 |
Codecov Report
@@ Coverage Diff @@
## master #3875 +/- ##
==========================================
- Coverage 91.57% 91.55% -0.03%
==========================================
Files 185 185
Lines 36555 36556 +1
==========================================
- Hits 33477 33468 -9
- Misses 3078 3088 +10 |
3 similar comments
Codecov Report
@@ Coverage Diff @@
## master #3875 +/- ##
==========================================
- Coverage 91.57% 91.55% -0.03%
==========================================
Files 185 185
Lines 36555 36556 +1
==========================================
- Hits 33477 33468 -9
- Misses 3078 3088 +10 |
Codecov Report
@@ Coverage Diff @@
## master #3875 +/- ##
==========================================
- Coverage 91.57% 91.55% -0.03%
==========================================
Files 185 185
Lines 36555 36556 +1
==========================================
- Hits 33477 33468 -9
- Misses 3078 3088 +10 |
Codecov Report
@@ Coverage Diff @@
## master #3875 +/- ##
==========================================
- Coverage 91.57% 91.55% -0.03%
==========================================
Files 185 185
Lines 36555 36556 +1
==========================================
- Hits 33477 33468 -9
- Misses 3078 3088 +10 |
Append IF NOT EXISTS to CREATE SERVER commands generated by pg_get_serverdef_string
function when deparsing an existing server object that a foreign table depends in order to
provide possible errors if we will execute the returned DDL command in the same node.