Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non deterministic collation test to work with ancient libicu versions #4097

Merged
merged 1 commit into from Aug 7, 2020

Conversation

serprex
Copy link
Member

@serprex serprex commented Aug 5, 2020

CentOS 7's libicu is too old for und-u-ks-level2

@colStrength=secondary works with both older & newer versions of libicu

Fixes #4096

@serprex serprex requested a review from thanodnl August 5, 2020 15:27
marcocitus
marcocitus previously approved these changes Aug 5, 2020
@marcocitus marcocitus dismissed their stale review August 5, 2020 20:05

might make sense for someone with a Mac to test this

@SaitTalhaNisanci
Copy link
Contributor

might make sense for someone with a Mac to test this

@hanefi or @thanodnl

Copy link
Member

@onderkalaci onderkalaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked fine on mac

@marcocitus marcocitus force-pushed the fix-case-insensitive-test-on-old-icu branch from c4a626d to f45073b Compare August 7, 2020 11:03
…ions

CentOS 7's libicu is too old for und-u-ks-level2

@colStrength=secondary works with both older & newer versions of libicu
@serprex serprex force-pushed the fix-case-insensitive-test-on-old-icu branch from f45073b to 212ae71 Compare August 7, 2020 12:34
@serprex serprex merged commit 7d5c856 into master Aug 7, 2020
@serprex serprex deleted the fix-case-insensitive-test-on-old-icu branch August 7, 2020 12:46
@metdos metdos added this to the 9.5 Release milestone Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pg12 collation test fails on some platforms
5 participants