Rename create_citus_local_table to citus_add_local_table_to_metadata

[onurctirtir]

DESCRIPTION: Drops support for create_citus_local_table in favor of citus_add_local_table_to_metadata

For simplicity in downgrade tests, didn't actually remove
create_citus_local_table udf.
Also made some small changes in error messages not
to mention create_citus_local_table udf anymore.

[codecov]

Codecov Report

Merging #4573 (8151c4b) into master (1c7ee10) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4573   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files         212      212           
  Lines       42479    42483    +4     
=======================================
+ Hits        39353    39359    +6     
+ Misses       3126     3124    -2     

[marcocitus]

I think we can remove/rename the SQL-level create_citus_local_table, just not the C-level create_citus_local_table.

[onurctirtir]

I think we can remove/rename the SQL-level create_citus_local_table, just not the C-level create_citus_local_table.

I tried to remove create_citus_citus_local_table dir, but then builds fail as 9.5-1 script still needs this directory.
So intead, I got rid of citus_add_clocal_table_to_metadata directory and moved 10.0-1 script to create_citus_citus_local_table dir. (41729cc)

Then I needed to rename create_citus_local_table udf in regression tests since now we don't have that in 10.0-1 (4be3db7)

What do you think @marcocitus ?

[onderkalaci]

In addition to that, did not rename .c & .sql files and did not replace
create_citus_local_table with citus_add_local_table_to_metadata in
regression tests.

I think it'd better to rename this files as well?

[onderkalaci]

I think it'd better to rename this files as well?

at least the c file

[onderkalaci]

We have never exposed create_citus_local_table to the users. So, instead, can we simply give a ERROR saying that use citus_add_local_table_to_metadata ?

As you noted we had create_citus_local_table on the change log of 9.5, still we never showed in docs/blogs etc. And, with Citus 10, it should be OK to break some users.

Maybe add one line of extra DESCRIPTION: Drops support for create_citus_local_table in favor of citus_add_local_table_to_metadata or such

[marcocitus]

This C function only exists to support testing 9.5->10.0 downgrade with a 10.0 binary (not a real scenario, just something our tests do). It does not matter much what we do here, since it should never be called in practice.

[onurctirtir]

True, but we have a test in those downgrade steps that first creates a citus local table in citus 9.5 and we error out if we try to downgrade back to 9.4, so I think we still need that udf in binary.
Or, I can remove that test too but not sure if this is a good option.

[onderkalaci]

I'd at least add a notice that create_citus_local_table is deprecated and use citus_add_local_table_to_metadata instead

[marcocitus]

Looks ok to me.

[onderkalaci]

I have a slight preference to rename the file to citus_add_local_table_to_metadata.